Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

Issue 1308533006: webapps: allow callers of icon downloader/selector to specify a minimum size (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webapps-splashscreen-icon
Patch Set: Fix non-compiling test Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
index e5eb34358b32777d778d3c3d9754d26b4fde6e2e..cf5b818eeca4ed3c4f620169d4ea0eff2befe755 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java
@@ -69,9 +69,7 @@ public class AppBannerManager extends EmptyTabObserver {
* @param tab Tab that the AppBannerManager will be attached to.
*/
public AppBannerManager(Tab tab, Context context) {
- mNativePointer = nativeInit(
- ShortcutHelper.getIdealSplashImageSizeInDp(context.getResources()),
- ShortcutHelper.getIdealIconSizeInDp(context.getResources()));
+ mNativePointer = nativeInit();
mTab = tab;
updatePointers();
}
@@ -165,7 +163,7 @@ public class AppBannerManager extends EmptyTabObserver {
}
private static native boolean nativeIsEnabled();
- private native long nativeInit(int idealSplashImageSizeInDp, int idealIconSizeInDp);
+ private native long nativeInit();
private native void nativeDestroy(long nativeAppBannerManagerAndroid);
private native void nativeReplaceWebContents(long nativeAppBannerManagerAndroid,
WebContents webContents);

Powered by Google App Engine
This is Rietveld 408576698