webapps: allow callers of icon downloader/selector to specify a minimum size

chrome/browser/android/banners/app_banner_data_fetcher_android.cc

Index: chrome/browser/android/banners/app_banner_data_fetcher_android.cc
diff --git a/chrome/browser/android/banners/app_banner_data_fetcher_android.cc b/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
index d18eb59f058d297612600e3c46a6fb644af42965..6ffbb0219c2e5d75011436ab9f52e381ecf3d9da 100644
--- a/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
+++ b/chrome/browser/android/banners/app_banner_data_fetcher_android.cc
@@ -19,9 +19,15 @@ AppBannerDataFetcherAndroid::AppBannerDataFetcherAndroid(
     content::WebContents* web_contents,
     base::WeakPtr<Delegate> weak_delegate,
     int ideal_splash_image_size_in_dp,
-    int ideal_icon_size_in_dp)
-    : AppBannerDataFetcher(web_contents, weak_delegate, ideal_icon_size_in_dp),
-      ideal_splash_image_size_in_dp_(ideal_splash_image_size_in_dp) {
+    int minimum_splash_image_size_in_dp,
+    int ideal_icon_size_in_dp,
+    int minimum_icon_size_in_dp)
+    : AppBannerDataFetcher(web_contents,
+                           weak_delegate,
+                           ideal_icon_size_in_dp,
+                           minimum_icon_size_in_dp),
+      ideal_splash_image_size_in_dp_(ideal_splash_image_size_in_dp),
+      minimum_splash_image_size_in_dp_(minimum_splash_image_size_in_dp) {

[dominickn, 2015/09/11 00:29:58]

Nit: reorder the parameters so that the base class constructor arguments come
first, and then the additional splash screen arguments.

[Lalit Maganti, 2015/09/11 13:06:00]

Done.

 }
 
 AppBannerDataFetcherAndroid::~AppBannerDataFetcherAndroid() {
@@ -56,10 +62,15 @@ void AppBannerDataFetcherAndroid::FetchWebappSplashScreenImage(
   GURL image_url = ManifestIconSelector::FindBestMatchingIcon(
       web_app_data().icons,
       ideal_splash_image_size_in_dp_,
+      minimum_splash_image_size_in_dp_,
       gfx::Screen::GetScreenFor(web_contents->GetNativeView()));
 
   ShortcutHelper::FetchSplashScreenImage(
-      web_contents, image_url, ideal_splash_image_size_in_dp_, webapp_id);
+      web_contents,
+      image_url,
+      ideal_splash_image_size_in_dp_,
+      minimum_splash_image_size_in_dp_,
+      webapp_id);
 }
 
 void AppBannerDataFetcherAndroid::ShowBanner(const SkBitmap* icon,