Cast:Updating logging stats

media/cast/logging/logging_impl.h

Index: media/cast/logging/logging_impl.h
diff --git a/media/cast/logging/logging_impl.h b/media/cast/logging/logging_impl.h
index bf518699c230dd37ae722c0c8a16fcd8fa2431a4..65a2d2372274ed88c1fe08cf032044ce53a29eb3 100644
--- a/media/cast/logging/logging_impl.h
+++ b/media/cast/logging/logging_impl.h
@@ -62,16 +62,16 @@ class LoggingImpl : public base::NonThreadSafe {
                           int value);
 
   // Get raw data.
-  FrameRawMap GetFrameRawData();
-  PacketRawMap GetPacketRawData();
-  GenericRawMap GetGenericRawData();
+  FrameRawMap GetFrameRawData() const;
+  PacketRawMap GetPacketRawData() const;
+  GenericRawMap GetGenericRawData() const;
   AudioRtcpRawMap GetAudioRtcpRawData();

[imcheng, 2014/01/22 21:03:37]

GetAudioRtcpRawData() and GetVideoRtcpRawData() behave differently from the
other three above in that they reset the underlying map. Could this be
documented?

[hguihot1, 2014/01/22 21:13:05]

Or could it be consistent and not Reset()?

On 2014/01/22 21:03:37, imcheng1 wrote:

[mikhal1, 2014/01/23 19:53:11]

Get and reset makes more sense for this use case, and keeping it.
On 2014/01/22 21:13:05, hguihot1 wrote:

[mikhal1, 2014/01/23 19:53:11]

Done.

   VideoRtcpRawMap GetVideoRtcpRawData();
 
   // Get stats only (computed when called). Triggers UMA stats when enabled.
-  const FrameStatsMap* GetFrameStatsData(const base::TimeTicks& now);
-  const PacketStatsMap* GetPacketStatsData(const base::TimeTicks& now);
-  const GenericStatsMap* GetGenericStatsData();
+  const FrameStatsMap* GetFrameStatsData() const;
+  const PacketStatsMap* GetPacketStatsData() const;
+  const GenericStatsMap* GetGenericStatsData() const;
 
   // Reset raw logging data.

[imcheng, 2014/01/22 21:03:37]

Document that this does not reset AudioRtcpRawMap and VideoRtcpRawMap.

[mikhal1, 2014/01/23 19:53:11]

Done.

   void ResetRaw();