Cast:Updating logging stats

media/cast/logging/logging_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 #ifndef MEDIA_CAST_LOGGING_LOGGING_IMPL_H_
 #define MEDIA_CAST_LOGGING_LOGGING_IMPL_H_
 
 // Generic class that handles event logging for the cast library.
 // Logging has three possible optional forms:
 // 1. Raw data and stats accessible by the application.
 // 2. UMA stats.
@@ skipping 44 matching lines @@
                          uint32 frame_id,
                          uint16 packet_id,
                          uint16 max_packet_id,
                          size_t size);
 
   void InsertGenericEvent(const base::TimeTicks& time_of_event,
                           CastLoggingEvent event,
                           int value);
 
   // Get raw data.
-  FrameRawMap GetFrameRawData();
-  PacketRawMap GetPacketRawData();
-  GenericRawMap GetGenericRawData();
+  FrameRawMap GetFrameRawData() const;
+  PacketRawMap GetPacketRawData() const;
+  GenericRawMap GetGenericRawData() const;
   AudioRtcpRawMap GetAudioRtcpRawData();

[imcheng, 2014/01/22 21:03:37]

GetAudioRtcpRawData() and GetVideoRtcpRawData() behave differently from the
other three above in that they reset the underlying map. Could this be
documented?

[hguihot1, 2014/01/22 21:13:05]

Or could it be consistent and not Reset()?

On 2014/01/22 21:03:37, imcheng1 wrote:

[mikhal1, 2014/01/23 19:53:11]

Get and reset makes more sense for this use case, and keeping it.
On 2014/01/22 21:13:05, hguihot1 wrote:

[mikhal1, 2014/01/23 19:53:11]

Done.

   VideoRtcpRawMap GetVideoRtcpRawData();
 
   // Get stats only (computed when called). Triggers UMA stats when enabled.
-  const FrameStatsMap* GetFrameStatsData(const base::TimeTicks& now);
-  const PacketStatsMap* GetPacketStatsData(const base::TimeTicks& now);
-  const GenericStatsMap* GetGenericStatsData();
+  const FrameStatsMap* GetFrameStatsData() const;
+  const PacketStatsMap* GetPacketStatsData() const;
+  const GenericStatsMap* GetGenericStatsData() const;
 
   // Reset raw logging data.

[imcheng, 2014/01/22 21:03:37]

Document that this does not reset AudioRtcpRawMap and VideoRtcpRawMap.

[mikhal1, 2014/01/23 19:53:11]

Done.

   void ResetRaw();
   // Reset stats logging data.
   void ResetStats();
 
  private:
   void InsertGenericUmaEvent(CastLoggingEvent event, int value);
   scoped_refptr<base::TaskRunner> main_thread_proxy_;
   const CastLoggingConfig config_;
   LoggingRaw raw_;
   LoggingStats stats_;
 
   DISALLOW_COPY_AND_ASSIGN(LoggingImpl);
 };
 
 }  // namespace cast
 }  // namespace media
 
 #endif  // MEDIA_CAST_LOGGING_LOGGING_IMPL_H_