Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1301343002: add null-aware operators to the language tour (Closed)

Created:
5 years, 4 months ago by Kathy Walrath
Modified:
5 years, 4 months ago
Reviewers:
gbracha, sethladd
Base URL:
https://github.com/dart-lang/www.dartlang.org.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 3

Patch Set 2 : incorporate Gilad's review comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -22 lines) Patch
A src/site/_includes/null-aware-1-12.html View 1 chunk +7 lines, -0 lines 0 comments Download
M src/site/docs/dart-up-and-running/ch02.markdown View 1 10 chunks +109 lines, -21 lines 0 comments Download
M src/site/docs/dart-up-and-running/ch03.markdown View 1 chunk +1 line, -1 line 0 comments Download
M src/site/docs/dart-up-and-running/preface.markdown View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Kathy Walrath
Gilad and/or Seth, could you please take a look?
5 years, 4 months ago (2015-08-20 22:22:52 UTC) #2
gbracha
One minor comment; otherwise lgtm https://chromiumcodereview.appspot.com/1301343002/diff/1/src/site/docs/dart-up-and-running/ch02.markdown File src/site/docs/dart-up-and-running/ch02.markdown (right): https://chromiumcodereview.appspot.com/1301343002/diff/1/src/site/docs/dart-up-and-running/ch02.markdown#newcode1273 src/site/docs/dart-up-and-running/ch02.markdown:1273: To assign only if ...
5 years, 4 months ago (2015-08-20 23:44:16 UTC) #3
Kathy Walrath
Thanks, Gilad! I have a question... https://chromiumcodereview.appspot.com/1301343002/diff/1/src/site/docs/dart-up-and-running/ch02.markdown File src/site/docs/dart-up-and-running/ch02.markdown (right): https://chromiumcodereview.appspot.com/1301343002/diff/1/src/site/docs/dart-up-and-running/ch02.markdown#newcode1273 src/site/docs/dart-up-and-running/ch02.markdown:1273: To assign only ...
5 years, 4 months ago (2015-08-20 23:56:52 UTC) #4
Kathy Walrath
https://chromiumcodereview.appspot.com/1301343002/diff/1/src/site/docs/dart-up-and-running/ch02.markdown File src/site/docs/dart-up-and-running/ch02.markdown (right): https://chromiumcodereview.appspot.com/1301343002/diff/1/src/site/docs/dart-up-and-running/ch02.markdown#newcode1273 src/site/docs/dart-up-and-running/ch02.markdown:1273: To assign only if the assigned-to object is null, ...
5 years, 4 months ago (2015-08-21 00:31:08 UTC) #5
Kathy Walrath
5 years, 4 months ago (2015-08-21 00:32:28 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c56e3641d2657c5da260eb717bdd095e75342eb1 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698