Issue 12982018: Move string_piece.h to base/strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12982018: Move string_piece.h to base/strings. (Closed)

Created:
7 years, 9 months ago by brettw

Modified:
7 years, 9 months ago

Reviewers:
jam

CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

Move string_piece.h to base/strings. This keeps a forwarding header and does not update any code to use the new location. This will be updated in a later pass. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191206

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1389 lines)			Patch
M	base/base.gyp	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	base/base.gypi	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	base/string_piece.h	View	1 2	1 chunk	+3 lines, -448 lines	0 comments	Download
D	base/string_piece.cc	View		1 chunk	+0 lines, -255 lines	0 comments	Download
D	base/string_piece_unittest.cc	View		1 chunk	+0 lines, -677 lines	0 comments	Download
A +	base/strings/string_piece.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
A +	base/strings/string_piece.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
A +	base/strings/string_piece_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

brettw

7 years, 9 months ago (2013-03-28 20:07:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r191206 (presubmit successful).