Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 12943010: Add native permissions dialog for apps_devtools app. (Closed)

Created:
7 years, 9 months ago by Gaurav
Modified:
7 years, 8 months ago
CC:
chromium-reviews, Aaron Boodman, arv+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add native permissions dialog for apps_devtools app. BUG=149036 TBR=dbeam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191526

Patch Set 1 #

Total comments: 18

Patch Set 2 : comments #

Patch Set 3 : . #

Total comments: 1

Patch Set 4 : comment #

Patch Set 5 : rebase #

Patch Set 6 : reused the ReviewPermissions in extension_install_prompt.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -77 lines) Patch
M chrome/browser/extensions/api/developer_private/developer_private_api.h View 1 2 3 4 5 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 1 2 3 4 5 1 chunk +38 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_function_histogram_value.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
D chrome/browser/resources/apps_debugger/css/permissions_overlay.css View 1 chunk +0 lines, -30 lines 0 comments Download
M chrome/browser/resources/apps_debugger/js/items.js View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/apps_debugger/js/items_list.js View 1 2 3 4 2 chunks +2 lines, -19 lines 0 comments Download
M chrome/browser/resources/apps_debugger/main.html View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
D chrome/browser/resources/apps_debugger/permissions_overlay.html View 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/common/extensions/api/developer_private.idl View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
Gaurav
@asargent chrome/browser/extensions/* chrome/common/extensions/* @dbeam chrome/browser/resources/*
7 years, 9 months ago (2013-03-20 18:41:40 UTC) #1
Dan Beam
https://codereview.chromium.org/12943010/diff/1/chrome/browser/resources/apps_debugger/js/items_list.js File chrome/browser/resources/apps_debugger/js/items_list.js (right): https://codereview.chromium.org/12943010/diff/1/chrome/browser/resources/apps_debugger/js/items_list.js#newcode423 chrome/browser/resources/apps_debugger/js/items_list.js:423: setTimeout(ItemsList.loadItemsInfo, 1000); so... where'd we land on making this ...
7 years, 9 months ago (2013-03-20 19:55:32 UTC) #2
Gaurav
https://chromiumcodereview.appspot.com/12943010/diff/1/chrome/browser/resources/apps_debugger/js/items_list.js File chrome/browser/resources/apps_debugger/js/items_list.js (right): https://chromiumcodereview.appspot.com/12943010/diff/1/chrome/browser/resources/apps_debugger/js/items_list.js#newcode423 chrome/browser/resources/apps_debugger/js/items_list.js:423: setTimeout(ItemsList.loadItemsInfo, 1000); On 2013/03/20 19:55:33, Dan Beam wrote: > ...
7 years, 9 months ago (2013-03-20 21:01:15 UTC) #3
asargent_no_longer_on_chrome
https://codereview.chromium.org/12943010/diff/1/chrome/browser/extensions/api/developer_private/developer_private_api.cc File chrome/browser/extensions/api/developer_private/developer_private_api.cc (right): https://codereview.chromium.org/12943010/diff/1/chrome/browser/extensions/api/developer_private/developer_private_api.cc#newcode457 chrome/browser/extensions/api/developer_private/developer_private_api.cc:457: const Extension* extension = service->GetInstalledExtension(extension_id); You should handle the ...
7 years, 9 months ago (2013-03-20 21:46:30 UTC) #4
Dan Beam
https://chromiumcodereview.appspot.com/12943010/diff/1/chrome/browser/resources/apps_debugger/js/items_list.js File chrome/browser/resources/apps_debugger/js/items_list.js (right): https://chromiumcodereview.appspot.com/12943010/diff/1/chrome/browser/resources/apps_debugger/js/items_list.js#newcode423 chrome/browser/resources/apps_debugger/js/items_list.js:423: setTimeout(ItemsList.loadItemsInfo, 1000); On 2013/03/20 21:01:15, Gaurav wrote: > On ...
7 years, 9 months ago (2013-03-20 21:47:28 UTC) #5
Gaurav
https://codereview.chromium.org/12943010/diff/1/chrome/browser/extensions/api/developer_private/developer_private_api.cc File chrome/browser/extensions/api/developer_private/developer_private_api.cc (right): https://codereview.chromium.org/12943010/diff/1/chrome/browser/extensions/api/developer_private/developer_private_api.cc#newcode457 chrome/browser/extensions/api/developer_private/developer_private_api.cc:457: const Extension* extension = service->GetInstalledExtension(extension_id); On 2013/03/20 21:46:30, Antony ...
7 years, 9 months ago (2013-03-27 19:06:44 UTC) #6
Gaurav
https://chromiumcodereview.appspot.com/12943010/diff/1/chrome/browser/resources/apps_debugger/js/items_list.js File chrome/browser/resources/apps_debugger/js/items_list.js (right): https://chromiumcodereview.appspot.com/12943010/diff/1/chrome/browser/resources/apps_debugger/js/items_list.js#newcode423 chrome/browser/resources/apps_debugger/js/items_list.js:423: setTimeout(ItemsList.loadItemsInfo, 1000); On 2013/03/20 21:47:28, Dan Beam wrote: > ...
7 years, 9 months ago (2013-03-27 19:07:16 UTC) #7
asargent_no_longer_on_chrome
LGTM https://chromiumcodereview.appspot.com/12943010/diff/14001/chrome/browser/extensions/extension_install_prompt.h File chrome/browser/extensions/extension_install_prompt.h (right): https://chromiumcodereview.appspot.com/12943010/diff/14001/chrome/browser/extensions/extension_install_prompt.h#newcode297 chrome/browser/extensions/extension_install_prompt.h:297: virtual void PermissionsDialog(Delegate* delegate, nit: Please add a ...
7 years, 9 months ago (2013-03-27 19:27:04 UTC) #8
Gaurav
@dbeam TBR as the code in chrome/extensions/resources is just deletion.
7 years, 9 months ago (2013-03-27 20:50:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/12943010/20001
7 years, 9 months ago (2013-03-27 20:56:48 UTC) #10
Dan Beam
lgtm
7 years, 9 months ago (2013-03-27 21:13:00 UTC) #11
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-27 22:52:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/12943010/20001
7 years, 9 months ago (2013-03-28 17:23:38 UTC) #13
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=27610
7 years, 9 months ago (2013-03-28 17:39:17 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/12943010/40001
7 years, 8 months ago (2013-03-29 17:52:44 UTC) #15
Dan Beam
FYI: like was mentioned on chromium-dev@, next time don't TBR "trivial" changes.
7 years, 8 months ago (2013-03-29 18:14:12 UTC) #16
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-03-29 18:16:55 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/12943010/42006
7 years, 8 months ago (2013-03-29 19:43:03 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/grv@chromium.org/12943010/42006
7 years, 8 months ago (2013-03-30 16:59:28 UTC) #19
commit-bot: I haz the power
7 years, 8 months ago (2013-03-30 17:40:05 UTC) #20
Message was sent while issue was closed.
Change committed as 191526

Powered by Google App Engine
This is Rietveld 408576698