Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7101)

Unified Diff: chrome/browser/resources/apps_debugger/js/items_list.js

Issue 12943010: Add native permissions dialog for apps_devtools app. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: reused the ReviewPermissions in extension_install_prompt.cc Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/apps_debugger/js/items_list.js
diff --git a/chrome/browser/resources/apps_debugger/js/items_list.js b/chrome/browser/resources/apps_debugger/js/items_list.js
index 08c35964af9af3a7fcf912cb2b0bf6c05a024c73..ccc9f7c1b703bce3d402583d1baaf5721f5c1c4e 100644
--- a/chrome/browser/resources/apps_debugger/js/items_list.js
+++ b/chrome/browser/resources/apps_debugger/js/items_list.js
@@ -276,23 +276,7 @@ cr.define('apps_dev_tool', function() {
setPermissionsLink_: function(item, el) {
var permissions = el.querySelector('.permissions-link');
permissions.addEventListener('click', function(e) {
- var permissionItem = $('permissions-item');
- permissionItem.textContent = '';
- chrome.management.getPermissionWarningsById(
- item.id,
- function(warnings) {
- warnings.forEach(function(permission) {
- var li = document.createElement('li');
- li.textContent = permission;
- permissionItem.appendChild(li);
- });
- AppsDevTool.showOverlay($('permissions-overlay'));
- });
-
- $('permissions-icon').style.backgroundImage =
- 'url(' + item.icon + ')';
- $('permissions-title').textContent = item.name;
- e.preventDefault();
+ chrome.developerPrivate.showPermissionsDialog(item.id);
});
},
@@ -435,8 +419,7 @@ cr.define('apps_dev_tool', function() {
*/
ItemsList.launchApp = function(id) {
chrome.management.launchApp(id, function() {
- // There is a delay in generation of background page for the app.
- setTimeout(ItemsList.loadItemsInfo, 1000);
+ ItemsList.loadItemsInfo();
});
};
« no previous file with comments | « chrome/browser/resources/apps_debugger/js/items.js ('k') | chrome/browser/resources/apps_debugger/main.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698