chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeWebActionModeCallback.java - Issue 1292923004: Refactor chrome's action mode logics and namings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeWebActionModeCallback.java

Issue 1292923004: Refactor chrome's action mode logics and namings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make webview to compile Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/ActionModeController.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeWebActionModeCallback.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeSelectActionModeCallback.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeWebActionModeCallback.java

similarity index 80%

rename from chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeSelectActionModeCallback.java

rename to chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeWebActionModeCallback.java

index a2ac69cdc5fbfecf716ff1a9bf185e6ca19f64dc..0e2b0aa240fffdeae1815286755e76e7a6ae2e7a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeSelectActionModeCallback.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeWebActionModeCallback.java

@@ -9,7 +9,7 @@ import android.view.ActionMode;

import android.view.Menu;

import org.chromium.chrome.R;

-import org.chromium.content.browser.SelectActionModeCallback;

+import org.chromium.content.browser.WebActionModeCallback;

import org.chromium.ui.base.DeviceFormFactor;

/**

@@ -17,8 +17,8 @@ import org.chromium.ui.base.DeviceFormFactor;

* changes:

* - sets the title for the action bar description based on tablet/phone UI.

-public class ChromeSelectActionModeCallback extends SelectActionModeCallback {

- ChromeSelectActionModeCallback(Context context, ActionHandler actionHandler) {

+public class ChromeWebActionModeCallback extends WebActionModeCallback {

+ ChromeWebActionModeCallback(Context context, ActionHandler actionHandler) {

super(context, actionHandler);

}