chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java - Issue 1292923004: Refactor chrome's action mode logics and namings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java

Issue 1292923004: Refactor chrome's action mode logics and namings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: make webview to compile Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeSelectActionModeCallback.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeWebActionModeCallback.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java

index 179dcc40f3be25ef0598044f825a3e9d74a55600..8b0fe2d895a960dc23b3e97578c5350a6c6991d7 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/ChromeTab.java

@@ -71,8 +71,8 @@ import org.chromium.content.browser.ActivityContentVideoViewClient;

import org.chromium.content.browser.ContentVideoViewClient;

import org.chromium.content.browser.ContentViewClient;

import org.chromium.content.browser.ContentViewCore;

-import org.chromium.content.browser.SelectActionMode;

-import org.chromium.content.browser.SelectActionModeCallback.ActionHandler;

+import org.chromium.content.browser.WebActionMode;

+import org.chromium.content.browser.WebActionModeCallback.ActionHandler;

import org.chromium.content.browser.crypto.CipherFactory;

import org.chromium.content_public.browser.GestureStateListener;

import org.chromium.content_public.browser.InvalidateTypes;

@@ -760,13 +760,13 @@ public class ChromeTab extends Tab {

}

@Override

- public SelectActionMode startActionMode(

+ public WebActionMode startActionMode(

View view, ActionHandler actionHandler, boolean floating) {

if (floating) return null;

- ChromeSelectActionModeCallback callback =

- new ChromeSelectActionModeCallback(view.getContext(), actionHandler);

+ ChromeWebActionModeCallback callback =

+ new ChromeWebActionModeCallback(view.getContext(), actionHandler);

ActionMode actionMode = view.startActionMode(callback);

- return actionMode != null ? new SelectActionMode(actionMode) : null;

+ return actionMode != null ? new WebActionMode(actionMode) : null;

}

@Override