dart:typeddata for dart2js

dart:typeddata for dart2js

This is still has a fair bit of cleanup to, but I wanted to let you guys
know where I'm at.  The APIs are close to, but not quite the same as
the VM version yet.  The fixed up html/typed_array tests pass in
Dart2JS using the new dart:typeddata instead.

Opens:

- The dartium code 'generated' by this is unused.  Probably it should
  be suppressed altogether?

- No bounds checking.  In fact, I'm surprised
  typed_arrays_range_check_test ever worked on Dartium - that test is
  kind of crazy.  :-)

- Still some minor API fixups (e.g., the ByteData constructors) to do.

- typeddata tests under standalone are not passing.  Will investigate.

- I will leave the 'new' types: Uint64*, Int64*, Float32x4*, etc., for
  a later CL.  Those will need to be handwritten, and possibly
  reworked if we want to generate efficient code.

- Should we keep ByteBuffer.supported?  TypedArrays are not available
  in IE 9.

[Mads Ager (google), 2013-03-19 10:09:09]

Great progress. :-)

I would have loved to patch this into my workspace but git cl patch cannot deal
with it and I cannot download it because of the size of the patch. :(

https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/typeddata/d...
File sdk/lib/typeddata/dartium/typeddata_dartium.dart (right):

https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/typeddata/d...
sdk/lib/typeddata/dartium/typeddata_dartium.dart:29: class ByteBuffer extends
NativeFieldWrapperClass1 {
This file should be empty for dartium since we will get the types from
dart:typeddata directly. That doesn open up for the question about handling
supported. The supported getter is not in the dart:typeddata library.

https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/typeddata/d...
sdk/lib/typeddata/dartium/typeddata_dartium.dart:43: dynamic slice(int begin,
[int end]) {
slice is not in dart:typeddata either. However, the typeddata lists are real
dart Lists so they have sublist (which used to be called getRange).

https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/typeddata/d...
sdk/lib/typeddata/dartium/typeddata_dartium.dart:496: List<num> getRange(int
start, int rangeLength) =>
On List this was renamed to sublist by lrn@. But maybe that didn't propagate all
the way to dart:html.

https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/typeddata/d...
sdk/lib/typeddata/dartium/typeddata_dartium.dart:508: List<double> subarray(int
start, [int end]) {
subarray is not on the dart typeddata lists I think.

[Anton Muhin, 2013-03-19 12:31:24]

neat!

First round of comments.

https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/html/dartiu...
File sdk/lib/html/dartium/html_dartium.dart (left):

https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/html/dartiu...
sdk/lib/html/dartium/html_dartium.dart:15767: -   
_TypedArrayFactoryProvider.createInt32Array(length);
shouldn't this _TypedArrayFactoryProvider class go away as well?

But I can clean it up myself later.

https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/html/dartiu...
File sdk/lib/html/dartium/html_dartium.dart (right):

https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/html/dartiu...
sdk/lib/html/dartium/html_dartium.dart:32812: +  static forwardingPrint(String
message) native "Utils_forwardingPrint";
nit: I've fixed this diff in a separate CL.  You may want to rebase your CL.

https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/typeddata/d...
File sdk/lib/typeddata/dart2js/typeddata_dart2js.dart (right):

https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/typeddata/d...
sdk/lib/typeddata/dart2js/typeddata_dart2js.dart:35: factory ByteBuffer(int
length) {
There are apparently no such constructor as of now, but I'd love to see one.

https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/typeddata/d...
sdk/lib/typeddata/dart2js/typeddata_dart2js.dart:49: ByteBuffer slice(int begin,
[int end]) {
again, typeddata doesn't support it yet.

Looks like we need to be more careful overall with the list of the things that
are exposed.

https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/web_audio/d...
File sdk/lib/web_audio/dart2js/web_audio_dart2js.dart (right):

https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/web_audio/d...
sdk/lib/web_audio/dart2js/web_audio_dart2js.dart:6: import 'dart:html_common';
import 'dart:typeddata'?

https://chromiumcodereview.appspot.com/12929005/diff/6005/tests/html/typed_ar...
File tests/html/typed_arrays_1_test.dart (right):

https://chromiumcodereview.appspot.com/12929005/diff/6005/tests/html/typed_ar...
tests/html/typed_arrays_1_test.dart:35: var a1 = new
Uint8List.fromList([0,0,1,0x45]);
There is no such beast.  But I think we should have it.

For now maybe something like mew Uint8List(4)..setRange(0, 4, [...]).

Ugly I know

https://chromiumcodereview.appspot.com/12929005/diff/6005/tests/html/typed_ar...
File tests/html/typed_arrays_2_test.dart (right):

https://chromiumcodereview.appspot.com/12929005/diff/6005/tests/html/typed_ar...
tests/html/typed_arrays_2_test.dart:14: if (!ByteBuffer.supported) {
we need to add that into the typeddata which should be simple.

https://chromiumcodereview.appspot.com/12929005/diff/6005/tests/standalone/ty...
File tests/standalone/typed_data_test.dart (right):

https://chromiumcodereview.appspot.com/12929005/diff/6005/tests/standalone/ty...
tests/standalone/typed_data_test.dart:32: // Expect.isFalse(typed_data is
Uint8List);
why?

https://chromiumcodereview.appspot.com/12929005/diff/6005/tools/dom/scripts/g...
File tools/dom/scripts/generator.py (right):

https://chromiumcodereview.appspot.com/12929005/diff/6005/tools/dom/scripts/g...
tools/dom/scripts/generator.py:82: 'Float32List': '_TypedArrayFactoryProvider',
do we still need those?

https://chromiumcodereview.appspot.com/12929005/diff/6005/tools/dom/scripts/g...
tools/dom/scripts/generator.py:394: # TODO(antonm): temporary ugly hack.
chances are this hack can go away now, but you can leave it to me to clean the
mess up

https://chromiumcodereview.appspot.com/12929005/diff/6005/tools/dom/scripts/h...
File tools/dom/scripts/htmldartgenerator.py (right):

https://chromiumcodereview.appspot.com/12929005/diff/6005/tools/dom/scripts/h...
tools/dom/scripts/htmldartgenerator.py:385: '\n  $(LIST_ANNOTATIONS)factory
$CTOR.fromList(List<$TYPE> list) =>\n'
none as of now

https://chromiumcodereview.appspot.com/12929005/diff/6005/tools/dom/scripts/s...
File tools/dom/scripts/systemhtml.py (right):

https://chromiumcodereview.appspot.com/12929005/diff/6005/tools/dom/scripts/s...
tools/dom/scripts/systemhtml.py:282: 'provider_name': 'document',
why?

[Mads Ager (google), 2013-03-19 12:40:50]

https://chromiumcodereview.appspot.com/12929005/diff/6005/tests/html/typed_ar...
File tests/html/typed_arrays_1_test.dart (right):

https://chromiumcodereview.appspot.com/12929005/diff/6005/tests/html/typed_ar...
tests/html/typed_arrays_1_test.dart:35: var a1 = new
Uint8List.fromList([0,0,1,0x45]);
On 2013/03/19 12:31:24, Anton Muhin wrote:
> There is no such beast.  But I think we should have it.
> 
> For now maybe something like mew Uint8List(4)..setRange(0, 4, [...]).
> 
> Ugly I know

On List in core there is a from(Iterable other) constructor. It could make sense
to add that to typeddata.

https://chromiumcodereview.appspot.com/12929005/diff/6005/tests/standalone/ty...
File tests/standalone/typed_data_test.dart (right):

https://chromiumcodereview.appspot.com/12929005/diff/6005/tests/standalone/ty...
tests/standalone/typed_data_test.dart:32: // Expect.isFalse(typed_data is
Uint8List);
On 2013/03/19 12:31:24, Anton Muhin wrote:
> why?

Because Uint8ClampedList inherits from Uint8List in typeddata I believe.

[Anton Muhin, 2013-03-19 13:22:33]

https://chromiumcodereview.appspot.com/12929005/diff/6005/tests/standalone/ty...
File tests/standalone/typed_data_test.dart (right):

https://chromiumcodereview.appspot.com/12929005/diff/6005/tests/standalone/ty...
tests/standalone/typed_data_test.dart:32: // Expect.isFalse(typed_data is
Uint8List);
It doesn't in sdk/lib/typeddata_base.dart nor in vm's variant.  Apparently.

On 2013/03/19 12:40:50, Mads Ager wrote:
> On 2013/03/19 12:31:24, Anton Muhin wrote:
> > why?
> 
> Because Uint8ClampedList inherits from Uint8List in typeddata I believe.

[Mads Ager (google), 2013-03-19 13:27:37]

https://chromiumcodereview.appspot.com/12929005/diff/6005/tests/standalone/ty...
File tests/standalone/typed_data_test.dart (right):

https://chromiumcodereview.appspot.com/12929005/diff/6005/tests/standalone/ty...
tests/standalone/typed_data_test.dart:32: // Expect.isFalse(typed_data is
Uint8List);
On 2013/03/19 13:22:34, Anton Muhin wrote:
> It doesn't in sdk/lib/typeddata_base.dart nor in vm's variant.  Apparently.

That is true. Hmm, maybe it never did? I was sure I saw that somewhere. Sorry
for the noise.

> On 2013/03/19 12:40:50, Mads Ager wrote:
> > On 2013/03/19 12:31:24, Anton Muhin wrote:
> > > why?
> > 
> > Because Uint8ClampedList inherits from Uint8List in typeddata I believe.
>

[vsm, 2013-03-19 15:20:03]

On 2013/03/19 10:09:09, Mads Ager wrote:
> Great progress. :-)
> 
> I would have loved to patch this into my workspace but git cl patch cannot
deal
> with it and I cannot download it because of the size of the patch. :(

Thanks for the comments!  I will rebase and upload a version of this patch
without the generated code.  That should appease git cl patch.  :-)

> 
>
https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/typeddata/d...
> File sdk/lib/typeddata/dartium/typeddata_dartium.dart (right):
> 
>
https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/typeddata/d...
> sdk/lib/typeddata/dartium/typeddata_dartium.dart:29: class ByteBuffer extends
> NativeFieldWrapperClass1 {
> This file should be empty for dartium since we will get the types from
> dart:typeddata directly. That doesn open up for the question about handling
> supported. The supported getter is not in the dart:typeddata library.
> 
>
https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/typeddata/d...
> sdk/lib/typeddata/dartium/typeddata_dartium.dart:43: dynamic slice(int begin,
> [int end]) {
> slice is not in dart:typeddata either. However, the typeddata lists are real
> dart Lists so they have sublist (which used to be called getRange).
> 
>
https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/typeddata/d...
> sdk/lib/typeddata/dartium/typeddata_dartium.dart:496: List<num> getRange(int
> start, int rangeLength) =>
> On List this was renamed to sublist by lrn@. But maybe that didn't propagate
all
> the way to dart:html.
> 
>
https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/typeddata/d...
> sdk/lib/typeddata/dartium/typeddata_dartium.dart:508: List<double>
subarray(int
> start, [int end]) {
> subarray is not on the dart typeddata lists I think.

[blois, 2013-03-19 17:26:11]

https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/typeddata/d...
File sdk/lib/typeddata/dart2js/typeddata_dart2js.dart (right):

https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/typeddata/d...
sdk/lib/typeddata/dart2js/typeddata_dart2js.dart:41: static bool get supported
=> JS('bool', 'typeof window.ArrayBuffer != "undefined"');
I do think the supported check is useful- we use it in a handful of tests and I
believe it's quite useful to be able to refer to.

https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/typeddata/d...
sdk/lib/typeddata/dart2js/typeddata_dart2js.dart:2205: static Float32List
createFloat32List(int length) => _F32(length);
Do we still need the provider? Not critical to remove, but the indirection seems
unnecessary.

https://chromiumcodereview.appspot.com/12929005/diff/6005/tests/html/typed_ar...
File tests/html/typed_arrays_1_test.dart (right):

https://chromiumcodereview.appspot.com/12929005/diff/6005/tests/html/typed_ar...
tests/html/typed_arrays_1_test.dart:35: var a1 = new
Uint8List.fromList([0,0,1,0x45]);
On 2013/03/19 12:40:50, Mads Ager wrote:
> On 2013/03/19 12:31:24, Anton Muhin wrote:
> > There is no such beast.  But I think we should have it.
> > 
> > For now maybe something like mew Uint8List(4)..setRange(0, 4, [...]).
> > 
> > Ugly I know
> 
> On List in core there is a from(Iterable other) constructor. It could make
sense
> to add that to typeddata.

Agree- I've seen unrelated bugs come through where people are using the
.fromList syntax, so it's in use today.

https://chromiumcodereview.appspot.com/12929005/diff/6005/tests/html/typed_ar...
File tests/html/typed_arrays_2_test.dart (right):

https://chromiumcodereview.appspot.com/12929005/diff/6005/tests/html/typed_ar...
tests/html/typed_arrays_2_test.dart:14: if (!ByteBuffer.supported) {
On 2013/03/19 12:31:24, Anton Muhin wrote:
> we need to add that into the typeddata which should be simple.

I also just noticed that Uint8ClampedArray is not supported by IE10. Joy.

https://chromiumcodereview.appspot.com/12929005/diff/6005/tools/dom/templates...
File tools/dom/templates/html/dart2js/html_dart2js.darttemplate (right):

https://chromiumcodereview.appspot.com/12929005/diff/6005/tools/dom/templates...
tools/dom/templates/html/dart2js/html_dart2js.darttemplate:19: import
'dart:typeddata';
Should be after svg.

https://chromiumcodereview.appspot.com/12929005/diff/6005/tools/dom/templates...
File tools/dom/templates/html/dart2js/typeddata_dart2js.darttemplate (right):

https://chromiumcodereview.appspot.com/12929005/diff/6005/tools/dom/templates...
tools/dom/templates/html/dart2js/typeddata_dart2js.darttemplate:1: // Copyright
(c) 2012, the Dart project authors.  Please see the AUTHORS file
2013

https://chromiumcodereview.appspot.com/12929005/diff/6005/tools/dom/templates...
tools/dom/templates/html/dart2js/typeddata_dart2js.darttemplate:9: /// The Dart
HTML library.
not HTML

https://chromiumcodereview.appspot.com/12929005/diff/6005/tools/dom/templates...
File tools/dom/templates/html/dartium/typeddata_dartium.darttemplate (right):

https://chromiumcodereview.appspot.com/12929005/diff/6005/tools/dom/templates...
tools/dom/templates/html/dartium/typeddata_dartium.darttemplate:1: // Copyright
(c) 2012, the Dart project authors.  Please see the AUTHORS file
2013

https://chromiumcodereview.appspot.com/12929005/diff/6005/tools/dom/templates...
tools/dom/templates/html/dartium/typeddata_dartium.darttemplate:9: /// The Dart
HTML library.
not HTML

[vsm, 2013-03-20 03:07:52]

Sorry, I didn't make much progress on this today.  Here's a version of this CL
that you can patch if you'd like:

https://chromiumcodereview.appspot.com/12580012/

https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/typeddata/d...
File sdk/lib/typeddata/dart2js/typeddata_dart2js.dart (right):

https://chromiumcodereview.appspot.com/12929005/diff/6005/sdk/lib/typeddata/d...
sdk/lib/typeddata/dart2js/typeddata_dart2js.dart:49: ByteBuffer slice(int begin,
[int end]) {
Yes, I do plan to go over this more carefully.  Even the list apis below -
setRange is supported on the VM, but throws below.

On 2013/03/19 12:31:24, Anton Muhin wrote:
> again, typeddata doesn't support it yet.
> 
> Looks like we need to be more careful overall with the list of the things that
> are exposed.

https://chromiumcodereview.appspot.com/12929005/diff/6005/tests/standalone/ty...
File tests/standalone/typed_data_test.dart (right):

https://chromiumcodereview.appspot.com/12929005/diff/6005/tests/standalone/ty...
tests/standalone/typed_data_test.dart:32: // Expect.isFalse(typed_data is
Uint8List);
Sorry, this file was an accidental inclusion.  I'm still looking into why this
test fails.  This was one of the things I hit.  In JS, Uint8ClampedArray
inherits from Uint8Array.  In Dart2JS today, it's hard to not have that
behavior, but Stephen thinks it'll be straightforward when interceptors become
more pervasive.

On 2013/03/19 13:27:37, Mads Ager wrote:
> On 2013/03/19 13:22:34, Anton Muhin wrote:
> > It doesn't in sdk/lib/typeddata_base.dart nor in vm's variant.  Apparently.
> 
> That is true. Hmm, maybe it never did? I was sure I saw that somewhere. Sorry
> for the noise.
> 
> > On 2013/03/19 12:40:50, Mads Ager wrote:
> > > On 2013/03/19 12:31:24, Anton Muhin wrote:
> > > > why?
> > > 
> > > Because Uint8ClampedList inherits from Uint8List in typeddata I believe.
> > 
>

[Anton Muhin, 2013-04-25 12:20:35]

time to close?