Add nacl_arch to data we send in omaha update checks for extensions/components

Add nacl_arch to data we send in omaha update checks for extensions/components

This is to support the webstore multi-crx feature

BUG=180402
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190614

[asargent_no_longer_on_chrome, 2013-03-23 00:05:33]

Carlos - please take a look

Jan - is it ok to consider the pnacl architecture to be the same as the NaCl
architecture? ncbray pointed me at
./ppapi/native_client/src/trusted/plugin/nexe_arch.h which seems to do the same
thing as your code, but seems much harder to use due to .gyp file weirdness,
etc. But perhaps we should unify the two in a separate CL?

[jvoung - send to chromium..., 2013-03-23 00:32:59]

On 2013/03/23 00:05:33, Antony Sargent wrote:
> Carlos - please take a look
> 
> Jan - is it ok to consider the pnacl architecture to be the same as the NaCl
> architecture?

Yes it should be the same.


ncbray pointed me at
> ./ppapi/native_client/src/trusted/plugin/nexe_arch.h which seems to do the
same
> thing as your code, but seems much harder to use due to .gyp file weirdness,
> etc. But perhaps we should unify the two in a separate CL?

Perhaps it could be unified, but probably not soon.  The
ppapi/native_client/src/trusted/plugin/* files used to live in the NaCl repo, so
it used to not depend on chrome sources other than ppapi. There is talk about
re-writing some of that to be more chromey, but I'm not sure where that stands.

[asargent_no_longer_on_chrome, 2013-03-25 03:31:06]

Sounds good. Jan, I guess you're actually in the OWNERS file for this directory
-  can you give lgtm if it looks ok?

[jvoung (off chromium), 2013-03-25 16:09:53]

lgtm

[asargent_no_longer_on_chrome, 2013-03-25 17:14:29]

thakis: please review changes to chrome/common/omaha_query_params.{h,cc}

(As an aside, these files probably deserve more specific owners - I'll create
another CL to move them into a subdirectory).

[Nico, 2013-03-25 17:21:25]

lgtm

https://codereview.chromium.org/12928004/diff/1/chrome/common/omaha_query_par...
File chrome/common/omaha_query_params.h (right):

https://codereview.chromium.org/12928004/diff/1/chrome/common/omaha_query_par...
chrome/common/omaha_query_params.h:38: // "arm", and "mips32".
Is there a good reason why this uses x86-32/64 while getArch() uses x86 / x64?

[asargent_no_longer_on_chrome, 2013-03-25 17:34:05]

On 2013/03/25 17:21:25, Nico wrote:
> lgtm
> 
>
https://codereview.chromium.org/12928004/diff/1/chrome/common/omaha_query_par...
> File chrome/common/omaha_query_params.h (right):
> 
>
https://codereview.chromium.org/12928004/diff/1/chrome/common/omaha_query_par...
> chrome/common/omaha_query_params.h:38: // "arm", and "mips32".
> Is there a good reason why this uses x86-32/64 while getArch() uses x86 / x64?

Good question - it's an unfortunate coincidence of the separate evolution of the
Omaha client/server protocol and NaCl manifest format. That's a good reminder to
me to touch base with the webstore and Omaha folks to see if it would make sense
to try and unify. The problem is that both styles are already entrenched within
different code bases / developer communities. =(

[commit-bot: I haz the power, 2013-03-25 17:48:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asargent@chromium.org/12928004/1

[commit-bot: I haz the power, 2013-03-25 18:51:48]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-03-25 23:23:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asargent@chromium.org/12928004/31001

[commit-bot: I haz the power, 2013-03-26 07:06:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asargent@chromium.org/12928004/31001

[commit-bot: I haz the power, 2013-03-26 09:13:08]

Change committed as 190614