Chromium Code Reviews
Help | Chromium Project | Sign in
(887)

Issue 12928004: Add nacl_arch to data we send in omaha update checks for extensions/components (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 1 month ago by Antony Sargent
Modified:
1 year ago
Reviewers:
jvoung (cr), Nico
CC:
chromium-reviews_chromium.org, cpu_(out until 23rd)
Visibility:
Public.

Description

Add nacl_arch to data we send in omaha update checks for extensions/components

This is to support the webstore multi-crx feature

BUG=180402
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190614

Patch Set 1 #

Total comments: 1

Patch Set 2 : add missing includes to fix windows compile error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -27 lines) Lint Patch
M chrome/browser/component_updater/pnacl/pnacl_component_installer.cc View 4 chunks +6 lines, -26 lines 0 comments 0 errors Download
M chrome/common/omaha_query_params.h View 1 chunk +14 lines, -0 lines 0 comments ? errors Download
M chrome/common/omaha_query_params.cc View 1 2 chunks +37 lines, -1 line 0 comments ? errors Download
Commit:

Messages

Total messages: 12
Antony Sargent
Carlos - please take a look Jan - is it ok to consider the pnacl ...
1 year, 1 month ago #1
jvoung - send to chromium...
On 2013/03/23 00:05:33, Antony Sargent wrote: > Carlos - please take a look > > ...
1 year, 1 month ago #2
Antony Sargent
Sounds good. Jan, I guess you're actually in the OWNERS file for this directory - ...
1 year, 1 month ago #3
jvoung (cr)
lgtm
1 year, 1 month ago #4
Antony Sargent
thakis: please review changes to chrome/common/omaha_query_params.{h,cc} (As an aside, these files probably deserve more specific ...
1 year, 1 month ago #5
Nico
lgtm https://codereview.chromium.org/12928004/diff/1/chrome/common/omaha_query_params.h File chrome/common/omaha_query_params.h (right): https://codereview.chromium.org/12928004/diff/1/chrome/common/omaha_query_params.h#newcode38 chrome/common/omaha_query_params.h:38: // "arm", and "mips32". Is there a good ...
1 year, 1 month ago #6
Antony Sargent
On 2013/03/25 17:21:25, Nico wrote: > lgtm > > https://codereview.chromium.org/12928004/diff/1/chrome/common/omaha_query_params.h > File chrome/common/omaha_query_params.h (right): > ...
1 year, 1 month ago #7
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/12928004/1
1 year, 1 month ago #8
I haz the power (commit-bot)
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
1 year ago #9
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/12928004/31001
1 year ago #10
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/12928004/31001
1 year ago #11
I haz the power (commit-bot)
1 year ago #12
Message was sent while issue was closed.
Change committed as 190614
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6