Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12912010: cc: Convert non-const reference arguments to pointers. (Closed)

Created:
7 years, 9 months ago by danakj
Modified:
7 years, 9 months ago
Reviewers:
jamesr, piman
CC:
chromium-reviews, cc-bugs_chromium.org, piman, backer
Visibility:
Public.

Description

cc: Convert non-const reference arguments to pointers. Style-only change. This is forbidden by the style guide. R=jamesr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190851

Patch Set 1 #

Patch Set 2 : rebasment #

Patch Set 3 : Fix ui/compositor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+705 lines, -580 lines) Patch
M cc/animation/layer_animation_controller.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M cc/animation/transform_operation.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/animation/transform_operation.cc View 1 9 chunks +34 lines, -32 lines 0 comments Download
M cc/animation/transform_operations.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/base/math_util.h View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/base/math_util.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M cc/base/region.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/base/region.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/base/region_unittest.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/base/scoped_ptr_algorithm.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/debug/overdraw_metrics.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M cc/output/delegating_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/delegating_renderer.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/output/delegating_renderer_unittest.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M cc/output/direct_renderer.h View 3 chunks +14 lines, -14 lines 0 comments Download
M cc/output/direct_renderer.cc View 1 7 chunks +36 lines, -35 lines 0 comments Download
M cc/output/gl_renderer.h View 3 chunks +20 lines, -20 lines 0 comments Download
M cc/output/gl_renderer.cc View 1 22 chunks +35 lines, -35 lines 0 comments Download
M cc/output/gl_renderer_pixeltest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/output/gl_renderer_unittest.cc View 1 14 chunks +32 lines, -24 lines 0 comments Download
M cc/output/renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/software_renderer.h View 2 chunks +12 lines, -12 lines 0 comments Download
M cc/output/software_renderer.cc View 10 chunks +15 lines, -15 lines 0 comments Download
M cc/output/software_renderer_unittest.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M cc/resources/picture_layer_tiling_set.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile_priority.cc View 1 2 chunks +10 lines, -4 lines 0 comments Download
M cc/trees/layer_sorter.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_common.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 7 chunks +20 lines, -20 lines 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 1 95 chunks +244 lines, -244 lines 0 comments Download
M cc/trees/quad_culler_unittest.cc View 1 19 chunks +186 lines, -78 lines 0 comments Download
M ui/compositor/layer.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
danakj
7 years, 9 months ago (2013-03-25 22:37:25 UTC) #1
jamesr
I'm pretty sure I fixed a number of these in the cpplint.py patches, mind letting ...
7 years, 9 months ago (2013-03-25 22:39:24 UTC) #2
danakj
On Mon, Mar 25, 2013 at 6:39 PM, <jamesr@chromium.org> wrote: > I'm pretty sure I ...
7 years, 9 months ago (2013-03-25 22:40:29 UTC) #3
danakj
rebased!
7 years, 9 months ago (2013-03-26 22:27:21 UTC) #4
jamesr
lgtm
7 years, 9 months ago (2013-03-26 22:40:33 UTC) #5
danakj
+piman for ui/
7 years, 9 months ago (2013-03-26 22:41:27 UTC) #6
piman
lgtm
7 years, 9 months ago (2013-03-26 22:45:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/12912010/9001
7 years, 9 months ago (2013-03-26 22:57:09 UTC) #8
commit-bot: I haz the power
7 years, 9 months ago (2013-03-27 07:40:42 UTC) #9
Message was sent while issue was closed. 
Change committed as 190851

Powered by Google App Engine
This is Rietveld 408576698