[mac] Create app shortcuts in a subfolder of /Applications

[mac] Create app shortcuts in a subfolder of /Applications

App shortcuts will be created in /Applications/Chrome Apps.localized, to
support future localization of the directory name (see
https://developer.apple.com/library/mac/#documentation/MacOSX/Conceptual/BPInternational/Articles/LocalizingPathnames.html
for details)

R=benwells@chromium.org, rsesek@chromium.org
BUG=180745
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188944

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189243

[benwells, 2013-03-18 05:01:17]

lgtm

https://codereview.chromium.org/12912003/diff/1/chrome/browser/web_applicatio...
File chrome/browser/web_applications/web_app_mac.mm (right):

https://codereview.chromium.org/12912003/diff/1/chrome/browser/web_applicatio...
chrome/browser/web_applications/web_app_mac.mm:152: const base::FilePath&
app_file_name) const {
Is there a reason this takes app_file_name?

[jeremya, 2013-03-18 05:27:55]

On 2013/03/18 05:01:17, benwells wrote:
> lgtm
> 
>
https://codereview.chromium.org/12912003/diff/1/chrome/browser/web_applicatio...
> File chrome/browser/web_applications/web_app_mac.mm (right):
> 
>
https://codereview.chromium.org/12912003/diff/1/chrome/browser/web_applicatio...
> chrome/browser/web_applications/web_app_mac.mm:152: const base::FilePath&
> app_file_name) const {
> Is there a reason this takes app_file_name?

... I guess not! Fixed.

[Robert Sesek, 2013-03-18 15:33:35]

Not all users are administrators, and so won't be able to write to /Applications
by default. ~/Applications would be okay, though

[jeremya, 2013-03-18 22:08:28]

On 2013/03/18 15:33:35, rsesek wrote:
> Not all users are administrators, and so won't be able to write to
/Applications
> by default. ~/Applications would be okay, though

The code already checks to see if /Applications is writable, and if so puts the
folder there, otherwise it goes in ~/Applications.

[Robert Sesek, 2013-03-18 22:09:35]

So it does. LGTM.

[commit-bot: I haz the power, 2013-03-18 23:29:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/12912003/4001

[commit-bot: I haz the power, 2013-03-19 00:21:46]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-03-19 00:41:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/12912003/20001

[commit-bot: I haz the power, 2013-03-19 03:41:50]

Change committed as 188944

[jeremya, 2013-03-20 00:22:44]

Reopened to reland since i've fixed the test now.

[commit-bot: I haz the power, 2013-03-20 00:27:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jeremya@chromium.org/12912003/37001

[commit-bot: I haz the power, 2013-03-20 11:57:36]

Change committed as 189243