Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: chrome/browser/web_applications/web_app_mac_unittest.mm

Issue 12912003: [mac] Create app shortcuts in a subfolder of /Applications (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fail if dirname of chrome apps dir doesn't exist or isn't a directory. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/web_applications/web_app_mac.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/web_applications/web_app_mac_unittest.mm
diff --git a/chrome/browser/web_applications/web_app_mac_unittest.mm b/chrome/browser/web_applications/web_app_mac_unittest.mm
index 75643f625c09337ba304ed7b0e6fc58342acf311..069a58487bbe6bf20630624f5bb19e74d4a16c7d 100644
--- a/chrome/browser/web_applications/web_app_mac_unittest.mm
+++ b/chrome/browser/web_applications/web_app_mac_unittest.mm
@@ -38,7 +38,7 @@ class WebAppShortcutCreatorMock : public web_app::WebAppShortcutCreator {
UTF8ToUTF16("fake.cfbundleidentifier")) {
}
- MOCK_CONST_METHOD1(GetDestinationPath, base::FilePath(const base::FilePath&));
+ MOCK_CONST_METHOD0(GetDestinationPath, base::FilePath());
MOCK_CONST_METHOD1(RevealGeneratedBundleInFinder,
void (const base::FilePath&));
};
@@ -67,7 +67,7 @@ TEST(WebAppShortcutCreatorTest, CreateShortcut) {
base::FilePath dst_path = dst_folder.Append(UTF16ToUTF8(info.title) + ".app");
NiceMock<WebAppShortcutCreatorMock> shortcut_creator(info);
- EXPECT_CALL(shortcut_creator, GetDestinationPath(_))
+ EXPECT_CALL(shortcut_creator, GetDestinationPath())
.WillRepeatedly(Return(dst_folder));
EXPECT_CALL(shortcut_creator, RevealGeneratedBundleInFinder(dst_path));
@@ -105,7 +105,7 @@ TEST(WebAppShortcutCreatorTest, RunShortcut) {
base::FilePath dst_path = dst_folder.Append(UTF16ToUTF8(info.title) + ".app");
NiceMock<WebAppShortcutCreatorMock> shortcut_creator(info);
- EXPECT_CALL(shortcut_creator, GetDestinationPath(_))
+ EXPECT_CALL(shortcut_creator, GetDestinationPath())
.WillRepeatedly(Return(dst_folder));
EXPECT_CALL(shortcut_creator, RevealGeneratedBundleInFinder(dst_path));
@@ -126,7 +126,7 @@ TEST(WebAppShortcutCreatorTest, CreateFailure) {
scoped_temp_dir.path().Append("not-existent").Append("name.app");
NiceMock<WebAppShortcutCreatorMock> shortcut_creator(GetShortcutInfo());
- EXPECT_CALL(shortcut_creator, GetDestinationPath(_))
+ EXPECT_CALL(shortcut_creator, GetDestinationPath())
.WillRepeatedly(Return(non_existent_path));
EXPECT_FALSE(shortcut_creator.CreateShortcut());
}
« no previous file with comments | « chrome/browser/web_applications/web_app_mac.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698