chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java - Issue 1288903002: Refactor ShortcutHelper and merge in BookmarkUtils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

Issue 1288903002: Refactor ShortcutHelper and merge in BookmarkUtils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test file name Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/appmenu/ChromeAppMenuPropertiesDelegate.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/bookmark/ShortcutActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

index 5d885496115c9759ce5cdc962a4460d682755dd0..b6fa211a2a05022efd039efa26b381a6f5aef463 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java

@@ -12,7 +12,7 @@ import org.chromium.base.VisibleForTesting;

import org.chromium.base.annotations.CalledByNative;

import org.chromium.base.annotations.JNINamespace;

import org.chromium.chrome.R;

-import org.chromium.chrome.browser.BookmarkUtils;

+import org.chromium.chrome.browser.ShortcutHelper;

import org.chromium.chrome.browser.tab.EmptyTabObserver;

import org.chromium.chrome.browser.tab.Tab;

import org.chromium.content_public.browser.WebContents;

@@ -51,7 +51,7 @@ public class AppBannerManager extends EmptyTabObserver {

public static boolean isEnabled() {

if (sIsEnabled == null) {

Context context = ApplicationStatus.getApplicationContext();

- sIsEnabled = nativeIsEnabled() && BookmarkUtils.isAddToHomeIntentSupported(context);

+ sIsEnabled = nativeIsEnabled() && ShortcutHelper.isAddToHomeIntentSupported(context);

}

return sIsEnabled;

}