chrome/android/java/src/org/chromium/chrome/browser/appmenu/ChromeAppMenuPropertiesDelegate.java - Issue 1288903002: Refactor ShortcutHelper and merge in BookmarkUtils

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/appmenu/ChromeAppMenuPropertiesDelegate.java

Issue 1288903002: Refactor ShortcutHelper and merge in BookmarkUtils (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix test file name Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ShortcutHelper.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/banners/AppBannerManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/appmenu/ChromeAppMenuPropertiesDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/ChromeAppMenuPropertiesDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/ChromeAppMenuPropertiesDelegate.java

index d16f68308d1ff18a73383429467680f5ad86345b..b2023923d1d20732285ff6776f4841f1a9982e12 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/appmenu/ChromeAppMenuPropertiesDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/appmenu/ChromeAppMenuPropertiesDelegate.java

@@ -11,11 +11,11 @@ import android.view.MenuItem;

import org.chromium.base.CommandLine;

import org.chromium.base.FieldTrialList;

import org.chromium.chrome.R;

-import org.chromium.chrome.browser.BookmarkUtils;

import org.chromium.chrome.browser.BookmarksBridge;

import org.chromium.chrome.browser.ChromeActivity;

import org.chromium.chrome.browser.ChromeBrowserProviderClient;

import org.chromium.chrome.browser.ChromeSwitches;

+import org.chromium.chrome.browser.ShortcutHelper;

import org.chromium.chrome.browser.UrlConstants;

import org.chromium.chrome.browser.offline_pages.OfflinePageBridge;

import org.chromium.chrome.browser.preferences.ManagedPreferencesUtils;

@@ -140,7 +140,7 @@ public class ChromeAppMenuPropertiesDelegate implements AppMenuPropertiesDelegat

// creating shortcuts is supported at all.

MenuItem homescreenItem = menu.findItem(R.id.add_to_homescreen_id);

boolean canAddShortcutToHomescreen =

- BookmarkUtils.isAddToHomeIntentSupported(mActivity);

+ ShortcutHelper.isAddToHomeIntentSupported(mActivity);

homescreenItem.setVisible(

canAddShortcutToHomescreen && !isChromeScheme && !isIncognito);