Removing command line switch to disable deferred 2d canvas.

Removing command line switch to disable deferred 2d canvas.

Also removing the lab in about:flags that references the switch.

BUG=195766
TEST=None.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190208

[jochen (gone - plz use gerrit), 2013-03-15 13:52:44]

https://codereview.chromium.org/12871012/diff/1/content/shell/webkit_test_con...
File content/shell/webkit_test_controller.cc (left):

https://codereview.chromium.org/12871012/diff/1/content/shell/webkit_test_con...
content/shell/webkit_test_controller.cc:297: prefs->deferred_2d_canvas_enabled =
true;
did you already remove the option from DumpRenderTree? If not, can you please do
that first?

[Jói, 2013-03-15 14:38:40]

LGTM for content/public, I'm assuming you just wanted me to look at that.

[jamesr, 2013-03-18 01:20:54]

webkit/ lgtm

https://codereview.chromium.org/12871012/diff/1/webkit/glue/webpreferences.cc
File webkit/glue/webpreferences.cc (right):

https://codereview.chromium.org/12871012/diff/1/webkit/glue/webpreferences.cc...
webkit/glue/webpreferences.cc:375: settings->setDeferred2dCanvasEnabled(true);
Are you planning to remove this value from WebSettings, etc, as well?

[Justin Novosad, 2013-03-20 20:00:54]

https://codereview.chromium.org/12871012/diff/1/content/shell/webkit_test_con...
File content/shell/webkit_test_controller.cc (left):

https://codereview.chromium.org/12871012/diff/1/content/shell/webkit_test_con...
content/shell/webkit_test_controller.cc:297: prefs->deferred_2d_canvas_enabled =
true;
On 2013/03/15 13:52:44, jochen wrote:
> did you already remove the option from DumpRenderTree? If not, can you please
do
> that first?
Done: http://trac.webkit.org/changeset/146351

https://codereview.chromium.org/12871012/diff/1/webkit/glue/webpreferences.cc
File webkit/glue/webpreferences.cc (right):

https://codereview.chromium.org/12871012/diff/1/webkit/glue/webpreferences.cc...
webkit/glue/webpreferences.cc:375: settings->setDeferred2dCanvasEnabled(true);
On 2013/03/18 01:20:54, jamesr wrote:
> Are you planning to remove this value from WebSettings, etc, as well?

Yes. In http://trac.webkit.org/changeset/146351 this method was made a stub, to
avoid blocking the WebKit roll. In the new patch I removed this line. As long as
this patch lands after the rolling WK past 146351, there will be no change in
default behavior on the chromium trunk. Once this patch lands, I will go back in
WK to remove the stub (and roll chromium DEPS if necessary).

[jochen (gone - plz use gerrit), 2013-03-20 20:08:37]

content/shell lgtm

[Justin Novosad, 2013-03-20 20:24:21]

Just missing content/browser OWNER. sky?

[commit-bot: I haz the power, 2013-03-21 14:04:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/junov@chromium.org/12871012/5002

[commit-bot: I haz the power, 2013-03-21 14:04:38]

Presubmit check for 12871012-5002 failed and returned exit status 1.

INFO:root:Found 9 file(s).

Running presubmit commit checks ...
Running /b/commit-queue/workdir/chromium/PRESUBMIT.py
Running /b/commit-queue/workdir/chromium/chrome/PRESUBMIT.py

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    content/browser/web_contents/web_contents_impl.cc

Presubmit checks took 1.3s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[sky, 2013-03-22 17:02:34]

LGTM

[commit-bot: I haz the power, 2013-03-22 18:58:44]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/junov@chromium.org/12871012/5002

[commit-bot: I haz the power, 2013-03-23 15:41:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/junov@chromium.org/12871012/5002

[commit-bot: I haz the power, 2013-03-24 05:26:25]

Change committed as 190208