Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 12871012: Removing command line switch to disable deferred 2d canvas. (Closed)

Created:
7 years, 9 months ago by Justin Novosad
Modified:
7 years, 9 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Removing command line switch to disable deferred 2d canvas. Also removing the lab in about:flags that references the switch. BUG=195766 TEST=None. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190208

Patch Set 1 #

Total comments: 4

Patch Set 2 : removed call to setDeferred2dCanvasEnabled in webpreferences.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/common/common_param_traits_macros.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M content/shell/webkit_test_controller.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/webkit_test_helpers.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/webpreferences.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M webkit/glue/webpreferences.cc View 1 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Justin Novosad
7 years, 9 months ago (2013-03-15 13:49:23 UTC) #1
jochen (gone - plz use gerrit)
https://codereview.chromium.org/12871012/diff/1/content/shell/webkit_test_controller.cc File content/shell/webkit_test_controller.cc (left): https://codereview.chromium.org/12871012/diff/1/content/shell/webkit_test_controller.cc#oldcode297 content/shell/webkit_test_controller.cc:297: prefs->deferred_2d_canvas_enabled = true; did you already remove the option ...
7 years, 9 months ago (2013-03-15 13:52:44 UTC) #2
Jói
LGTM for content/public, I'm assuming you just wanted me to look at that.
7 years, 9 months ago (2013-03-15 14:38:40 UTC) #3
jamesr
webkit/ lgtm https://codereview.chromium.org/12871012/diff/1/webkit/glue/webpreferences.cc File webkit/glue/webpreferences.cc (right): https://codereview.chromium.org/12871012/diff/1/webkit/glue/webpreferences.cc#newcode375 webkit/glue/webpreferences.cc:375: settings->setDeferred2dCanvasEnabled(true); Are you planning to remove this ...
7 years, 9 months ago (2013-03-18 01:20:54 UTC) #4
Justin Novosad
https://codereview.chromium.org/12871012/diff/1/content/shell/webkit_test_controller.cc File content/shell/webkit_test_controller.cc (left): https://codereview.chromium.org/12871012/diff/1/content/shell/webkit_test_controller.cc#oldcode297 content/shell/webkit_test_controller.cc:297: prefs->deferred_2d_canvas_enabled = true; On 2013/03/15 13:52:44, jochen wrote: > ...
7 years, 9 months ago (2013-03-20 20:00:54 UTC) #5
jochen (gone - plz use gerrit)
content/shell lgtm
7 years, 9 months ago (2013-03-20 20:08:37 UTC) #6
Justin Novosad
Just missing content/browser OWNER. sky?
7 years, 9 months ago (2013-03-20 20:24:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/12871012/5002
7 years, 9 months ago (2013-03-21 14:04:31 UTC) #8
commit-bot: I haz the power
Presubmit check for 12871012-5002 failed and returned exit status 1. INFO:root:Found 9 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-21 14:04:38 UTC) #9
sky
LGTM
7 years, 9 months ago (2013-03-22 17:02:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/12871012/5002
7 years, 9 months ago (2013-03-22 18:58:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/junov@chromium.org/12871012/5002
7 years, 9 months ago (2013-03-23 15:41:17 UTC) #12
commit-bot: I haz the power
7 years, 9 months ago (2013-03-24 05:26:25 UTC) #13
Message was sent while issue was closed.
Change committed as 190208

Powered by Google App Engine
This is Rietveld 408576698