Autofill:Autocheckout: Enable looking at all elements for Autocheckout flow (ignoring 3 element lim…

Autofill:Autocheckout: Enable looking at all elements for Autocheckout flow (ignoring 3 element limit in autofill@browser process).

This CL addresses two issues:
1. Enabling sending all the forms with one or more elements to Autofill Server (As against having >3 requirement for general Autofill).
2. AutofillAgent@Renderer process, assumes that its form_elements_ are ordered same as the order of elements in AutofillManager@browser's form_structures, this assumption is broken if a form has <3 fields or if it has user specified autofill type.

BUG=191242
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188903

[Raman Kakilate, 2013-03-15 16:57:45]

PTAL, thanks.

[Albert Bodenhamer, 2013-03-15 17:22:53]

https://codereview.chromium.org/12852003/diff/1/components/autofill/browser/a...
File components/autofill/browser/autofill_manager_unittest.cc (right):

https://codereview.chromium.org/12852003/diff/1/components/autofill/browser/a...
components/autofill/browser/autofill_manager_unittest.cc:207: // Populates
|form| with data corresponding to minimual name form along
spelling of "minimal".

I don't understand this comment.

[Raman Kakilate, 2013-03-15 17:39:22]

https://codereview.chromium.org/12852003/diff/1/components/autofill/browser/a...
File components/autofill/browser/autofill_manager_unittest.cc (right):

https://codereview.chromium.org/12852003/diff/1/components/autofill/browser/a...
components/autofill/browser/autofill_manager_unittest.cc:207: // Populates
|form| with data corresponding to minimual name form along
On 2013/03/15 17:22:53, Albert Bodenhamer wrote:
> spelling of "minimal".
> 
> I don't understand this comment.

Tried to simplify it. PTAL.

[Ilya Sherman, 2013-03-15 23:37:17]

Please update the form_structure_unittest tests as well.

https://codereview.chromium.org/12852003/diff/4001/components/autofill/browse...
File components/autofill/browser/autofill_manager_unittest.cc (right):

https://codereview.chromium.org/12852003/diff/4001/components/autofill/browse...
components/autofill/browser/autofill_manager_unittest.cc:518: void
set_autocheckout_url_prefix(std::string autocheckout_url_prefix) {
nit: Pass by const-reference.

https://codereview.chromium.org/12852003/diff/4001/components/autofill/browse...
components/autofill/browser/autofill_manager_unittest.cc:921:
ASSERT_EQ("/form.html",
nit: EXPECT_EQ

https://codereview.chromium.org/12852003/diff/4001/components/autofill/browse...
components/autofill/browser/autofill_manager_unittest.cc:922:
form_structures[0]->source_url().path());
nit: Looks like this fits on the previous line.  (I think this applies for
several others below as well.)

https://codereview.chromium.org/12852003/diff/4001/components/autofill/browse...
components/autofill/browser/autofill_manager_unittest.cc:923:
ASSERT_EQ("/userspecified.html",
nit: EXPECT_EQ

[Raman Kakilate, 2013-03-18 16:14:31]

Rebased and added test in form_structure_unittest.

https://codereview.chromium.org/12852003/diff/4001/components/autofill/browse...
File components/autofill/browser/autofill_manager_unittest.cc (right):

https://codereview.chromium.org/12852003/diff/4001/components/autofill/browse...
components/autofill/browser/autofill_manager_unittest.cc:518: void
set_autocheckout_url_prefix(std::string autocheckout_url_prefix) {
On 2013/03/15 23:37:18, Ilya Sherman wrote:
> nit: Pass by const-reference.

Done.

https://codereview.chromium.org/12852003/diff/4001/components/autofill/browse...
components/autofill/browser/autofill_manager_unittest.cc:921:
ASSERT_EQ("/form.html",
On 2013/03/15 23:37:18, Ilya Sherman wrote:
> nit: EXPECT_EQ

Done.

https://codereview.chromium.org/12852003/diff/4001/components/autofill/browse...
components/autofill/browser/autofill_manager_unittest.cc:922:
form_structures[0]->source_url().path());
On 2013/03/15 23:37:18, Ilya Sherman wrote:
> nit: Looks like this fits on the previous line.  (I think this applies for
> several others below as well.)

Done.

https://codereview.chromium.org/12852003/diff/4001/components/autofill/browse...
components/autofill/browser/autofill_manager_unittest.cc:923:
ASSERT_EQ("/userspecified.html",
On 2013/03/15 23:37:18, Ilya Sherman wrote:
> nit: EXPECT_EQ

Done.

[Ilya Sherman, 2013-03-18 22:25:40]

https://codereview.chromium.org/12852003/diff/8001/components/autofill/browse...
File components/autofill/browser/form_structure.cc (right):

https://codereview.chromium.org/12852003/diff/8001/components/autofill/browse...
components/autofill/browser/form_structure.cc:616: return false;
Did you intentionally move this code back?

[Raman Kakilate, 2013-03-18 22:36:01]

https://codereview.chromium.org/12852003/diff/8001/components/autofill/browse...
File components/autofill/browser/form_structure.cc (right):

https://codereview.chromium.org/12852003/diff/8001/components/autofill/browse...
components/autofill/browser/form_structure.cc:616: return false;
On 2013/03/18 22:25:40, Ilya Sherman wrote:
> Did you intentionally move this code back?

Yes. RequiredFillableFields() does IsAutocheckoutEnabled() check internally.

[Ilya Sherman, 2013-03-18 22:38:27]

LGTM, thanks.

[commit-bot: I haz the power, 2013-03-18 22:45:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ramankk@chromium.org/12852003/8001

[commit-bot: I haz the power, 2013-03-19 01:05:18]

Change committed as 188903