Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12834013: Stop the GLPrograms unit test from generating out of range attrib indices for effects. (Closed)

Created:
7 years, 9 months ago by bsalomon
Modified:
7 years, 9 months ago
Reviewers:
jvanverth1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

Stop the GLPrograms unit test from generating out of range attrib indices for effects. R=jvanverth@google.com Committed: http://code.google.com/p/skia/source/detail?r=8298

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M tests/GLProgramsTest.cpp View 1 chunk +10 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
bsalomon
7 years, 9 months ago (2013-03-21 13:56:03 UTC) #1
jvanverth1
lgtm
7 years, 9 months ago (2013-03-21 17:42:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/12834013/1
7 years, 9 months ago (2013-03-21 17:44:35 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-21 17:44:42 UTC) #4
Message was sent while issue was closed. 
Change committed as 8298

Powered by Google App Engine
This is Rietveld 408576698