chrome/browser/extensions/active_tab_permission_granter.cc - Issue 12792005: Allow extensions on chrome:// URLs, when flag is set and permission is explicitly requested

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/active_tab_permission_granter.cc

Issue 12792005: Allow extensions on chrome:// URLs, when flag is set and permission is explicitly requested (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Reinstate original pickle order; add scripts clause to content_script_chrome_url_invalid.json to av… Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/active_tab_permission_granter.cc

diff --git a/chrome/browser/extensions/active_tab_permission_granter.cc b/chrome/browser/extensions/active_tab_permission_granter.cc

index da3694a5599559ca8f5c6989bddbf6760619fff9..e900f51d44d340cd94699f84f44682de4739b3b0 100644

--- a/chrome/browser/extensions/active_tab_permission_granter.cc

+++ b/chrome/browser/extensions/active_tab_permission_granter.cc

@@ -41,7 +41,7 @@ void ActiveTabPermissionGranter::GrantIfRequested(const Extension* extension) {

if (IsGranted(extension))

return;

- URLPattern pattern(UserScript::kValidUserScriptSchemes);

+ URLPattern pattern(UserScript::ValidUserScriptSchemes());

if (pattern.Parse(web_contents()->GetURL().spec()) !=

URLPattern::PARSE_SUCCESS) {

// Pattern parsing could fail if this is an unsupported URL e.g. chrome://.

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/extensions/crx_installer.cc » ('j') | no next file with comments »