chrome/browser/extensions/crx_installer.cc - Issue 12792005: Allow extensions on chrome:// URLs, when flag is set and permission is explicitly requested

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/crx_installer.cc

Issue 12792005: Allow extensions on chrome:// URLs, when flag is set and permission is explicitly requested (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Reinstate original pickle order; add scripts clause to content_script_chrome_url_invalid.json to av… Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/crx_installer.cc

diff --git a/chrome/browser/extensions/crx_installer.cc b/chrome/browser/extensions/crx_installer.cc

index 02493db76b3974ed89d8237ac8d84c6b66eae82e..7cb71a351f61fe98ae620ce05884b5b0b821b85f 100644

--- a/chrome/browser/extensions/crx_installer.cc

+++ b/chrome/browser/extensions/crx_installer.cc

@@ -325,7 +325,7 @@ CrxInstallerError CrxInstaller::AllowInstall(const Extension* extension) {

// For self-hosted apps, verify that the entire extent is on the same

// host (or a subdomain of the host) the download happened from. There's

// no way for us to verify that the app controls any other hosts.

- URLPattern pattern(UserScript::kValidUserScriptSchemes);

+ URLPattern pattern(UserScript::ValidUserScriptSchemes());

pattern.SetHost(download_url_.host());

pattern.SetMatchSubdomains(true);

« no previous file with comments | « chrome/browser/extensions/active_tab_permission_granter.cc ('k') | chrome/browser/extensions/extension_prefs.cc » ('j') | no next file with comments »