Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 12789007: [Retry] SyncFS: store disabled origins in DriveMetadataStore (Closed)

Created:
7 years, 9 months ago by nhiroki
Modified:
7 years, 9 months ago
Reviewers:
kinuko, calvinlo, tzik
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch
Visibility:
Public.

Description

[Retry] SyncFS: store disabled origins in DriveMetadataStore Store disabled origins when extensions are disabled. Current implementation stores origins only for installed and enabled apps (i.e. batch sync origins and incremental sync origins). Therefore we cannot access files and metadata related to installed but disabled apps. This makes a difference between installing/uninstalling and enabling/disabling extensions. - register an origin when an extension is launched for the first time. - disable the origin when the extension is disabled (not unregister). - enable the origin when the extension is enabled. - unregister the origin when the extension is uninstalled. Original review: https://codereview.chromium.org/12744008/ BUG=184742 TEST=unit_test TEST=manual test (launch, reload, restart, disable, enable and uninstall an app) TBR=kinuko,tzik,calvinlo Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189228

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+593 lines, -135 lines) Patch
M chrome/browser/sync_file_system/drive_file_sync_service.h View 3 chunks +8 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_file_sync_service.cc View 7 chunks +110 lines, -19 lines 0 comments Download
M chrome/browser/sync_file_system/drive_metadata_store.h View 6 chunks +27 lines, -8 lines 0 comments Download
M chrome/browser/sync_file_system/drive_metadata_store.cc View 23 chunks +204 lines, -25 lines 0 comments Download
M chrome/browser/sync_file_system/drive_metadata_store_unittest.cc View 11 chunks +138 lines, -49 lines 0 comments Download
M chrome/browser/sync_file_system/local_file_sync_service.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/mock_remote_file_sync_service.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/remote_file_sync_service.h View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.cc View 3 chunks +87 lines, -28 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nhiroki
TBR-ing to original reviewers since there is no change from original review.
7 years, 9 months ago (2013-03-20 01:11:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/12789007/1
7 years, 9 months ago (2013-03-20 01:16:22 UTC) #2
commit-bot: I haz the power
7 years, 9 months ago (2013-03-20 09:24:28 UTC) #3
Message was sent while issue was closed.
Change committed as 189228

Powered by Google App Engine
This is Rietveld 408576698