Issue 1277863003: cleanup: move fieldType constants and functions to a separate file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1277863003: cleanup: move fieldType constants and functions to a separate file (Closed)

Created:
5 years, 4 months ago by skybrian

Modified:
5 years, 4 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/dart-protobuf.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+531 lines, -418 lines)			Patch
M	lib/protobuf.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	lib/src/protobuf/builder_info.dart	View		7 chunks	+26 lines, -28 lines	0 comments	Download
M	lib/src/protobuf/coded_buffer_writer.dart	View		5 chunks	+39 lines, -39 lines	0 comments	Download
M	lib/src/protobuf/field_info.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A	lib/src/protobuf/field_type.dart	View		1 chunk	+248 lines, -0 lines	0 comments	Download
M	lib/src/protobuf/generated_message.dart	View	1	34 chunks	+177 lines, -345 lines	0 comments	Download
M	lib/src/protobuf/unknown_field_set.dart	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	lib/src/protobuf/wire_format.dart	View		1 chunk	+34 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

skybrian

5 years, 4 months ago (2015-08-10 18:12:29 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
68a05f6ff6d819d655458b088c23a645c21486a8 (presubmit successful).