lib/src/protobuf/field_info.dart - Issue 1277863003: cleanup: move fieldType constants and functions to a separate file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/protobuf/field_info.dart

Issue 1277863003: cleanup: move fieldType constants and functions to a separate file (Closed) Base URL: git@github.com:dart-lang/dart-protobuf.git@master

Patch Set: _validateMessage should call _baseType, not callers Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: lib/src/protobuf/field_info.dart

diff --git a/lib/src/protobuf/field_info.dart b/lib/src/protobuf/field_info.dart

index a26c1ee2d9421942c45e63c36129ad51d183e86d..2a7051ab4f469ddc799ea0cf6772fecb2ad3f737 100644

--- a/lib/src/protobuf/field_info.dart

+++ b/lib/src/protobuf/field_info.dart

@@ -23,7 +23,7 @@ class FieldInfo {

this.makeDefault = findMakeDefault(type, defaultOrMaker);

static MakeDefaultFunc findMakeDefault(int type, dynamic defaultOrMaker) {

- if (defaultOrMaker == null) return GeneratedMessage._defaultForType(type);

+ if (defaultOrMaker == null) return FieldType._defaultForType(type);

if (defaultOrMaker is MakeDefaultFunc) return defaultOrMaker;

return () => defaultOrMaker;

}

« no previous file with comments | « lib/src/protobuf/coded_buffer_writer.dart ('k') | lib/src/protobuf/field_type.dart » ('j') | no next file with comments »