Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issue 12751007: Don't display navigation error pages during layout tests (Closed)

Created:
7 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 9 months ago
Reviewers:
piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

Don't display navigation error pages during layout tests BUG=111316 R=piman@chromium.org TEST=http/tests/loading/bad-server-subframe.html passes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188589

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M content/public/test/layouttest_support.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.h View 2 chunks +9 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/shell/shell_render_process_observer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/test/layouttest_support.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jochen (gone - plz use gerrit)
7 years, 9 months ago (2013-03-15 22:16:17 UTC) #1
piman
lgtm
7 years, 9 months ago (2013-03-16 02:25:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/12751007/1
7 years, 9 months ago (2013-03-16 12:19:31 UTC) #3
commit-bot: I haz the power
7 years, 9 months ago (2013-03-16 16:14:43 UTC) #4
Message was sent while issue was closed.
Change committed as 188589

Powered by Google App Engine
This is Rietveld 408576698