Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: test/cctest/test-heap-profiler.cc

Issue 12729023: first step to remove unsafe handles (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: 1 month rebase Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-heap-profiler.cc
diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc
index 59e7b8f25498896a962ae736a1af8a335cdc21ba..2464db70739415a688affd15847e1a7a4bb85cf8 100644
--- a/test/cctest/test-heap-profiler.cc
+++ b/test/cctest/test-heap-profiler.cc
@@ -29,6 +29,9 @@
#include <ctype.h>
+// TODO(dcarney): remove
+#define V8_ALLOW_ACCESS_TO_PERSISTENT_IMPLICIT
+
#include "v8.h"
#include "cctest.h"
@@ -1195,7 +1198,8 @@ class GraphWithImplicitRefs {
for (int i = 0; i < kObjectsCount; i++) {
objects_[i] = v8::Persistent<v8::Object>::New(isolate, v8::Object::New());
}
- (*env)->Global()->Set(v8_str("root_object"), objects_[0]);
+ (*env)->Global()->Set(v8_str("root_object"),
+ v8::Local<v8::Value>::New(isolate, objects_[0]));
}
~GraphWithImplicitRefs() {
instance_ = NULL;

Powered by Google App Engine
This is Rietveld 408576698