first step to remove unsafe handles

test/cctest/test-profile-generator.cc

Index: test/cctest/test-profile-generator.cc
diff --git a/test/cctest/test-profile-generator.cc b/test/cctest/test-profile-generator.cc
index 56b1788a85132140bfeb0d7bea36479f0f0deb36..1943c1d654e267f5c26036ff4a3e9238afc1aab8 100644
--- a/test/cctest/test-profile-generator.cc
+++ b/test/cctest/test-profile-generator.cc
@@ -27,6 +27,9 @@
 //
 // Tests of profiles generator and utilities.
 
+// TODO(dcarney): remove
+#define V8_ALLOW_ACCESS_TO_PERSISTENT_IMPLICIT
+
 #include "v8.h"
 #include "profile-generator-inl.h"
 #include "cctest.h"
@@ -876,7 +879,7 @@ TEST(RecordStackTraceAtStartProfiling) {
     env = v8::Context::New(&config);
   }
   v8::HandleScope scope(v8::Isolate::GetCurrent());
-  env->Enter();
+  (*env)->Enter();

[Sven Panne, 2013/04/30 07:31:22]

I am a bit confused: Why is this change necessary? Shouldn't Persistent have the
obvious operator*/operator-> pair?

[dcarney, 2013/04/30 07:43:21]

* and -> must die!

 
   CpuProfiler* profiler = i::Isolate::Current()->cpu_profiler();
   CHECK_EQ(0, profiler->GetProfilesCount());