Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12721004: Autofill:Autocomplete: Enable autocheckout of input elements of type password. This will support fi… (Closed)

Created:
7 years, 9 months ago by Raman Kakilate
Modified:
7 years, 9 months ago
CC:
chromium-reviews, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Autofill:Autocomplete: Enable autocheckout of input elements of type password. This will support fields like CVV which are created as password fields by some sites. BUG=187267 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189025

Patch Set 1 #

Total comments: 10

Patch Set 2 : Address review comments. #

Total comments: 6

Patch Set 3 : nits #

Patch Set 4 : Updated expectations for hueristic tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -39 lines) Patch
M chrome/renderer/autofill/form_autofill_browsertest.cc View 1 6 chunks +33 lines, -12 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/02_checkout_advanceautoparts.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/02_checkout_ae.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/03_checkout_cduniverse.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/03_checkout_hsn.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/04_checkout_jcrew.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/05_checkout_nordstrom.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/06_checkout_qvc.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/08_register_adobe.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/08_register_amazon.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/08_register_aol.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/08_register_bestbuy.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/08_register_continental.com.out View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/09_register_deviantart.com.out View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/09_register_ebay.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
chrome/test/data/autofill/heuristics/output/09_register_ecomm.dell.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/09_register_epson.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/09_register_google.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
chrome/test/data/autofill/heuristics/output/10_register_gymboree.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/10_register_hotels.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/10_register_imdb.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/10_register_jbox.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/10_register_live.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/11_register_livejournal.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/11_register_macys.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/11_register_mcphee.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/11_register_myspace.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/11_register_newegg.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/12_register_officedepot.com.out View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
chrome/test/data/autofill/heuristics/output/12_register_officemax.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/12_register_pyramidcollection.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/12_register_rediff.com.out View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/12_register_rei.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/13_register_rocketlawyer.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/13_register_signup.clicksor.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
chrome/test/data/autofill/heuristics/output/13_register_signup.live.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
chrome/test/data/autofill/heuristics/output/13_register_sourceforge.net.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/13_register_supershuttle.com.out View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/14_register_target.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/14_register_threadless.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
chrome/test/data/autofill/heuristics/output/14_register_trueblue.jetblue.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/14_register_uhaul.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/14_register_yahoo.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
chrome/test/data/autofill/heuristics/output/15_crbug_53075.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/17_crbug_98338.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/20_register_alaskaair.com.out View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/20_register_epson.com.mx.out View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M components/autofill/browser/form_structure.h View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M components/autofill/browser/form_structure.cc View 1 2 6 chunks +15 lines, -17 lines 0 comments Download
M components/autofill/browser/form_structure_unittest.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M components/autofill/renderer/form_autofill_util.cc View 1 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Raman Kakilate
PTAL.
7 years, 9 months ago (2013-03-15 23:03:11 UTC) #1
Ilya Sherman
https://codereview.chromium.org/12721004/diff/1/components/autofill/browser/form_structure_unittest.cc File components/autofill/browser/form_structure_unittest.cc (right): https://codereview.chromium.org/12721004/diff/1/components/autofill/browser/form_structure_unittest.cc#newcode2148 components/autofill/browser/form_structure_unittest.cc:2148: // Password fields shouldn't effect the signature. nit: "effect" ...
7 years, 9 months ago (2013-03-15 23:42:35 UTC) #2
Ilya Sherman
https://codereview.chromium.org/12721004/diff/1/components/autofill/browser/form_structure.cc File components/autofill/browser/form_structure.cc (right): https://codereview.chromium.org/12721004/diff/1/components/autofill/browser/form_structure.cc#newcode250 components/autofill/browser/form_structure.cc:250: if ((!field->is_checkable && !field->is_password_field) || You should also make ...
7 years, 9 months ago (2013-03-15 23:43:27 UTC) #3
Raman Kakilate
https://codereview.chromium.org/12721004/diff/1/components/autofill/browser/form_structure.cc File components/autofill/browser/form_structure.cc (right): https://codereview.chromium.org/12721004/diff/1/components/autofill/browser/form_structure.cc#newcode250 components/autofill/browser/form_structure.cc:250: if ((!field->is_checkable && !field->is_password_field) || On 2013/03/15 23:43:27, Ilya ...
7 years, 9 months ago (2013-03-18 17:54:00 UTC) #4
Ilya Sherman
LGTM with nits: https://codereview.chromium.org/12721004/diff/9001/components/autofill/browser/form_structure.cc File components/autofill/browser/form_structure.cc (right): https://codereview.chromium.org/12721004/diff/9001/components/autofill/browser/form_structure.cc#newcode249 components/autofill/browser/form_structure.cc:249: // servers. nit: Please update this ...
7 years, 9 months ago (2013-03-18 22:33:45 UTC) #5
Raman Kakilate
https://codereview.chromium.org/12721004/diff/9001/components/autofill/browser/form_structure.cc File components/autofill/browser/form_structure.cc (right): https://codereview.chromium.org/12721004/diff/9001/components/autofill/browser/form_structure.cc#newcode249 components/autofill/browser/form_structure.cc:249: // servers. On 2013/03/18 22:33:46, Ilya Sherman wrote: > ...
7 years, 9 months ago (2013-03-18 23:01:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ramankk@chromium.org/12721004/11004
7 years, 9 months ago (2013-03-18 23:38:46 UTC) #7
Raman Kakilate
On 2013/03/18 23:38:46, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 9 months ago (2013-03-19 03:06:27 UTC) #8
Raman Kakilate
Updated expectations.
7 years, 9 months ago (2013-03-19 03:36:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ramankk@chromium.org/12721004/35001
7 years, 9 months ago (2013-03-19 05:02:57 UTC) #10
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-19 05:10:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ramankk@chromium.org/12721004/35001
7 years, 9 months ago (2013-03-19 14:30:20 UTC) #12
commit-bot: I haz the power
7 years, 9 months ago (2013-03-19 15:49:23 UTC) #13
Message was sent while issue was closed. 
Change committed as 189025

Powered by Google App Engine
This is Rietveld 408576698