Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: components/autofill/renderer/form_autofill_util.cc

Issue 12721004: Autofill:Autocomplete: Enable autocheckout of input elements of type password. This will support fi… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated expectations for hueristic tests Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/autofill/browser/form_structure_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/renderer/form_autofill_util.cc
diff --git a/components/autofill/renderer/form_autofill_util.cc b/components/autofill/renderer/form_autofill_util.cc
index 8b0e6fbe0cec32f89f1af074b335468b5e52217e..a0bbc4363d57972384bfeef0a713fcd0fb863673 100644
--- a/components/autofill/renderer/form_autofill_util.cc
+++ b/components/autofill/renderer/form_autofill_util.cc
@@ -590,13 +590,9 @@ namespace autofill {
const size_t kMaxParseableFields = 100;
-// In HTML5, all text fields except password are text input fields to
-// autocomplete.
+// All text fields, including password fields, should be extracted.
bool IsTextInput(const WebInputElement* element) {
- if (!element)
- return false;
-
- return element->isTextField() && !element->isPasswordField();
+ return element && element->isTextField();
}
bool IsSelectElement(const WebFormControlElement& element) {
« no previous file with comments | « components/autofill/browser/form_structure_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698