filemanager: Files App change necessary to use "drive/root". It still works with "drive".

filemanager: Files App change necessary to use "drive/root". It still works with "drive".

Refactor some methods and leave TODOs to support subroots "drive/{root,other}".

BUG=174233
TEST=unittests. Open Files App and verify Google Drive is available.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188353

[Haruki Sato, 2013-03-15 05:24:28]

This is one of the split CLs.
This still works with "drive" and we'll need another CL to use "drive/root".

[yoshiki, 2013-03-15 06:26:58]

lgtm with nits

https://codereview.chromium.org/12716015/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/directory_model.js (right):

https://codereview.chromium.org/12716015/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/directory_model.js:68: 
nit: remove

https://codereview.chromium.org/12716015/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/path_util.js (right):

https://codereview.chromium.org/12716015/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/path_util.js:30: * Sub root directory
for Drive. "root" and "other".
nit: This seems not to be used now. Please add some comment unless the
succeeding patch(es) comes shortly.

[Haruki Sato, 2013-03-15 06:49:47]

https://codereview.chromium.org/12716015/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/directory_model.js (right):

https://codereview.chromium.org/12716015/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/directory_model.js:68: 
On 2013/03/15 06:26:58, yoshiki wrote:
> nit: remove

Done. Thanks.

https://codereview.chromium.org/12716015/diff/1/chrome/browser/resources/file...
File chrome/browser/resources/file_manager/js/path_util.js (right):

https://codereview.chromium.org/12716015/diff/1/chrome/browser/resources/file...
chrome/browser/resources/file_manager/js/path_util.js:30: * Sub root directory
for Drive. "root" and "other".
On 2013/03/15 06:26:58, yoshiki wrote:
> nit: This seems not to be used now. Please add some comment unless the
> succeeding patch(es) comes shortly.

Done. Thanks.

[commit-bot: I haz the power, 2013-03-15 06:50:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/haruki@chromium.org/12716015/5001

[commit-bot: I haz the power, 2013-03-15 12:01:02]

Change committed as 188353