Remove CalculateContentsScale max texture size DCHECK.

Remove CalculateContentsScale max texture size DCHECK.

These DCHECKs are not relevant in solid color scrollbars mode.  For the
texture-based scrollbars case, there's an identical DCHECK in
SetTexturePriorities.

This fixes an Android test that started failing after boundsContainPageScale
stopped being set on scrollbar layers.

NOTRY=true
BUG=222069
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190500

[aelias_OOO_until_Jul13, 2013-03-25 21:42:58]

PTAL.

[jamesr, 2013-03-25 21:45:36]

https://codereview.chromium.org/12704023/diff/1/cc/layers/scrollbar_layer.cc
File cc/layers/scrollbar_layer.cc (left):

https://codereview.chromium.org/12704023/diff/1/cc/layers/scrollbar_layer.cc#...
cc/layers/scrollbar_layer.cc:107: DCHECK_LE(content_bounds->height(),
MaxTextureSize());
Can you leave these DCHECKs enabled when not in solid color scrollbar mode?

[mnaganov (inactive), 2013-03-25 21:45:52]

LGTM % enabling testSetInitialScale

https://codereview.chromium.org/12704023/diff/1/android_webview/javatests/src...
File
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
(right):

https://codereview.chromium.org/12704023/diff/1/android_webview/javatests/src...
android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java:2477:
public void testSetInitialScale() throws Throwable {
Please also re-enable this one, it should also work!

[aelias_OOO_until_Jul13, 2013-03-25 21:49:42]

On 2013/03/25 21:45:36, jamesr wrote:
> https://codereview.chromium.org/12704023/diff/1/cc/layers/scrollbar_layer.cc
> File cc/layers/scrollbar_layer.cc (left):
> 
>
https://codereview.chromium.org/12704023/diff/1/cc/layers/scrollbar_layer.cc#...
> cc/layers/scrollbar_layer.cc:107: DCHECK_LE(content_bounds->height(),
> MaxTextureSize());
> Can you leave these DCHECKs enabled when not in solid color scrollbar mode?

There's already some identical DCHECKs in SetTexturePriorities where the
contentBounds are actually used to size the scrollbar texture.  So we should
still be equally protected after deleting these.

[danakj, 2013-03-25 21:52:10]

https://codereview.chromium.org/12704023/diff/1003/cc/layers/scrollbar_layer.cc
File cc/layers/scrollbar_layer.cc (left):

https://codereview.chromium.org/12704023/diff/1003/cc/layers/scrollbar_layer....
cc/layers/scrollbar_layer.cc:106: DCHECK_LE(content_bounds->width(),
MaxTextureSize());
How about doing these if you're not in solid color mode? Since this was a bug
not so long ago.

[danakj, 2013-03-25 21:52:45]

On 2013/03/25 21:49:42, aelias wrote:
> On 2013/03/25 21:45:36, jamesr wrote:
> > https://codereview.chromium.org/12704023/diff/1/cc/layers/scrollbar_layer.cc
> > File cc/layers/scrollbar_layer.cc (left):
> > 
> >
>
https://codereview.chromium.org/12704023/diff/1/cc/layers/scrollbar_layer.cc#...
> > cc/layers/scrollbar_layer.cc:107: DCHECK_LE(content_bounds->height(),
> > MaxTextureSize());
> > Can you leave these DCHECKs enabled when not in solid color scrollbar mode?
> 
> There's already some identical DCHECKs in SetTexturePriorities where the
> contentBounds are actually used to size the scrollbar texture.  So we should
> still be equally protected after deleting these.

Oh. /me reads the whole thread. I guess I missed this earlier.

[danakj, 2013-03-25 21:53:36]

cc/ lgtm

[joth, 2013-03-25 22:14:51]

aw/ lgtm 2

[commit-bot: I haz the power, 2013-03-25 22:28:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aelias@chromium.org/12704023/1003

[commit-bot: I haz the power, 2013-03-25 22:48:05]

Change committed as 190500