Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java

Issue 12704023: Remove CalculateContentsScale max texture size DCHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Re-enable another test Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/layers/scrollbar_layer.cc » ('j') | cc/layers/scrollbar_layer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
index a9f4cdded7f64eabd4af423ad40355e69c72991a..07a0e4f99d8156f9a42308826902a84f295b43bb 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java
@@ -2435,12 +2435,8 @@ public class AwSettingsTest extends AndroidWebViewTestBase {
views.getContents1(), views.getClient1(), true));
}
- /*
@SmallTest
@Feature({"AndroidWebView", "Preferences"})
- Crashing in DCHECK after webkit roll. See crbug.com/222069.
- */
- @DisabledTest
// Verify that LoadViewOverviewMode doesn't affect pages with initial scale
// set in the viewport tag.
public void testLoadWithOverviewModeViewportScale() throws Throwable {
@@ -2472,12 +2468,8 @@ public class AwSettingsTest extends AndroidWebViewTestBase {
assertEquals((float)pageScale, getScaleOnUiThread(awContents));
}
- /*
@SmallTest
@Feature({"AndroidWebView", "Preferences"})
- Crashing in DCHECK after webkit roll. See crbug.com/222069.
- */
- @DisabledTest
public void testSetInitialScale() throws Throwable {
final TestAwContentsClient contentClient = new TestAwContentsClient();
final AwTestContainerView testContainerView =
« no previous file with comments | « no previous file | cc/layers/scrollbar_layer.cc » ('j') | cc/layers/scrollbar_layer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698