chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc - Issue 12703039: Inconsistent use of [x] close panel icon. Code changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

Issue 12703039: Inconsistent use of [x] close panel icon. Code changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added recently added local NTP file. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

diff --git a/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc b/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

index d3a14cccb866347cc996b3f505e1db089e048aac..005850776976f68ad5218b956931912cae85f924 100644

--- a/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

+++ b/chrome/browser/ui/views/sync/one_click_signin_bubble_view.cc

@@ -110,11 +110,11 @@ void OneClickSigninDialogView::InitContent(views::GridLayout* layout) {

close_button_ = new views::ImageButton(this);

close_button_->SetImage(views::ImageButton::STATE_NORMAL,

- rb.GetImageNamed(IDR_CLOSE_BAR).ToImageSkia());

+ rb.GetImageNamed(IDR_CLOSE_2).ToImageSkia());

close_button_->SetImage(views::ImageButton::STATE_HOVERED,

- rb.GetImageNamed(IDR_CLOSE_BAR_H).ToImageSkia());

+ rb.GetImageNamed(IDR_CLOSE_2_H).ToImageSkia());

close_button_->SetImage(views::ImageButton::STATE_PRESSED,

- rb.GetImageNamed(IDR_CLOSE_BAR_P).ToImageSkia());

+ rb.GetImageNamed(IDR_CLOSE_2_P).ToImageSkia());

layout->AddView(close_button_);

}

« no previous file with comments | « chrome/browser/ui/views/notifications/balloon_view_views.cc ('k') | chrome/browser/ui/views/tabs/tab.cc » ('j') | no next file with comments »