Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 12701022: wrongbaseurl OSX App List Pager and root view controller. (Closed)

Created:
7 years, 9 months ago by tapted
Modified:
7 years, 9 months ago
Reviewers:
CC:
chromium-reviews, tfarina, sail+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@20130304-crbug-138633-osx-app-list-demo-polish-macbook
Visibility:
Public.

Description

OSX App List Pager and root view controller. Adds a root AppListView for the OSX app list, and moves ownership of the AppListViewDelegate there (as well as principal ownership of the GridController). The root view contains the apps grid, a pager control, and a background. An AppsPaginationModelObserver feeds scroll changes on the grid to the view controller to update the pager (an NSSegmentedControl). BUG=138633 TEST=Added app_list_unittests: AppListViewControllerTest.*, AppsGridControllerTest.PaginationObserver*

Patch Set 1 : cleanups #

Patch Set 2 : rebase, about to squash and split #

Patch Set 3 : split #

Patch Set 4 : fix sizing in 10.6, add objectAtIndex #

Patch Set 5 : delegate should be owned by viewcontroller, test coverage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+677 lines, -145 lines) Patch
M chrome/browser/ui/cocoa/app_list/app_list_controller_cocoa.mm View 1 2 3 4 2 chunks +3 lines, -5 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
A ui/app_list/cocoa/app_list_view_controller.h View 1 2 3 4 1 chunk +39 lines, -0 lines 0 comments Download
A ui/app_list/cocoa/app_list_view_controller.mm View 1 2 3 4 1 chunk +151 lines, -0 lines 0 comments Download
A ui/app_list/cocoa/app_list_view_controller_unittest.mm View 1 2 3 4 1 chunk +83 lines, -0 lines 0 comments Download
M ui/app_list/cocoa/app_list_window_controller.h View 1 2 3 4 1 chunk +4 lines, -5 lines 0 comments Download
M ui/app_list/cocoa/app_list_window_controller.mm View 1 2 3 4 2 chunks +18 lines, -11 lines 0 comments Download
M ui/app_list/cocoa/app_list_window_controller_unittest.mm View 1 2 3 4 3 chunks +4 lines, -6 lines 0 comments Download
M ui/app_list/cocoa/apps_grid_controller.h View 1 2 3 4 3 chunks +15 lines, -6 lines 0 comments Download
M ui/app_list/cocoa/apps_grid_controller.mm View 1 2 3 4 11 chunks +57 lines, -15 lines 0 comments Download
M ui/app_list/cocoa/apps_grid_controller_unittest.mm View 1 2 3 4 3 chunks +110 lines, -97 lines 0 comments Download
A ui/app_list/cocoa/apps_pagination_model_observer.h View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download
A ui/app_list/cocoa/test/apps_grid_controller_test_helper.h View 1 2 3 4 1 chunk +64 lines, -0 lines 0 comments Download
A ui/app_list/cocoa/test/apps_grid_controller_test_helper.mm View 1 2 3 4 1 chunk +102 lines, -0 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698