Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 12693020: Since v8:13964, flags is uint32, so always use cmp on ARM. (Closed)

Created:
7 years, 9 months ago by Toon Verwaest
Modified:
7 years, 9 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Since v8:13964, flags is uint32, so always use cmp on ARM. Committed: https://code.google.com/p/v8/source/detail?r=13967

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M src/arm/stub-cache-arm.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
7 years, 9 months ago (2013-03-18 14:29:47 UTC) #1
Jakob Kummerow
lgtm
7 years, 9 months ago (2013-03-18 14:30:26 UTC) #2
Toon Verwaest
7 years, 9 months ago (2013-03-18 14:31:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r13967 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698