src/arm/stub-cache-arm.cc - Issue 12693020: Since v8:13964, flags is uint32, so always use cmp on ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/stub-cache-arm.cc

Issue 12693020: Since v8:13964, flags is uint32, so always use cmp on ARM. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/stub-cache-arm.cc

diff --git a/src/arm/stub-cache-arm.cc b/src/arm/stub-cache-arm.cc

index e3d27f11cf5e4d8d54da5c715ebcd6d3bb3a36ae..3350c56c163762f4464dabd0e153685116b6e973 100644

--- a/src/arm/stub-cache-arm.cc

+++ b/src/arm/stub-cache-arm.cc

@@ -102,12 +102,7 @@ static void ProbeTable(Isolate* isolate,

uint32_t mask = Code::kFlagsNotUsedInLookup;

ASSERT(__ ImmediateFitsAddrMode1Instruction(mask));

__ bic(flags_reg, flags_reg, Operand(mask));

- // Using cmn and the negative instead of cmp means we can use movw.

- if (flags < 0) {

- __ cmn(flags_reg, Operand(-flags));

- } else {

- __ cmp(flags_reg, Operand(flags));

- }

+ __ cmp(flags_reg, Operand(flags));

__ b(ne, &miss);

#ifdef DEBUG

« no previous file with comments | « no previous file | no next file » | no next file with comments »