Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Unified Diff: remoting/host/screen_resolution.h

Issue 12678008: Reworked the plumbing required to pass the client resolution to the desktop resizer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: CR feedback. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/host/resizing_host_observer_unittest.cc ('k') | remoting/host/screen_resolution.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/screen_resolution.h
diff --git a/remoting/host/screen_resolution.h b/remoting/host/screen_resolution.h
new file mode 100644
index 0000000000000000000000000000000000000000..5652a5a0f7f1f90e5c47b8a7036145bcc7ca1fd3
--- /dev/null
+++ b/remoting/host/screen_resolution.h
@@ -0,0 +1,41 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_HOST_SCREEN_RESOLUTION_H_
+#define REMOTING_HOST_SCREEN_RESOLUTION_H_
+
+#include "base/basictypes.h"
+#include "base/compiler_specific.h"
+#include "third_party/skia/include/core/SkPoint.h"
+#include "third_party/skia/include/core/SkSize.h"
+
+namespace remoting {
+
+// This structure describes the screen's dimensions and DPI.
Wez 2013/03/16 01:03:25 nit: the -> a
Wez 2013/03/16 01:03:25 nit: his isn't actually specific to screens - it's
alexeypa (please no reviews) 2013/03/16 22:20:09 Done.
alexeypa (please no reviews) 2013/03/16 22:20:09 I prefer to leave it as it is. I don't think is it
+struct ScreenResolution {
Wez 2013/03/16 01:03:25 As per style-guide this should be a class, not a s
alexeypa (please no reviews) 2013/03/16 22:20:09 Done.
+ ScreenResolution();
+
+ ScreenResolution(const SkISize& dimensions, const SkIPoint& dpi);
+
+ // Returns the screen dimensions scaled assording to the passed |new_dpi|.
Wez 2013/03/16 01:03:25 typo: assording
alexeypa (please no reviews) 2013/03/16 22:20:09 Done.
+ SkISize ScaleDimensionsToDpi(const SkIPoint& new_dpi) const;
Wez 2013/03/16 01:03:25 The problem with general scale to DPI is that it m
alexeypa (please no reviews) 2013/03/16 22:20:09 This change does not belong to this CL.
+
+ // Returns true if |dimensions_| specifies an empty rectangle or when
+ // IsValid() returns false.
+ bool IsEmpty() const;
+
+ // Returns true if both |dimensions_| and |dpi_| are valid. |dimensions_|
+ // specifying an empty rectangle is considered to be valid.
+ bool IsValid() const;
+
+ // Dimensions of the screen in pixels.
+ SkISize dimensions_;
Wez 2013/03/16 01:03:25 As per style-guide, struct members shouldn't have
alexeypa (please no reviews) 2013/03/16 22:20:09 It is a class now.
+
+ // The vertical and horizontal DPI of the screen.
+ SkIPoint dpi_;
+};
+
+} // namespace remoting
+
+#endif // REMOTING_HOST_SCREEN_RESOLUTION_H_
« no previous file with comments | « remoting/host/resizing_host_observer_unittest.cc ('k') | remoting/host/screen_resolution.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698