remoting/host/screen_resolution.h - Issue 12678008: Reworked the plumbing required to pass the client resolution to the desktop resizer.

Side by Side Diff: remoting/host/screen_resolution.h

Issue 12678008: Reworked the plumbing required to pass the client resolution to the desktop resizer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: CR feedback. Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef REMOTING_HOST_SCREEN_RESOLUTION_H_

	6 #define REMOTING_HOST_SCREEN_RESOLUTION_H_

	7

	8 #include "base/basictypes.h"

	9 #include "base/compiler_specific.h"

	10 #include "third_party/skia/include/core/SkPoint.h"

	11 #include "third_party/skia/include/core/SkSize.h"

	12

	13 namespace remoting {

	14

	15 // This structure describes the screen's dimensions and DPI.
	Wez 2013/03/16 01:03:25 nit: the -> a nit: the -> a Wez 2013/03/16 01:03:25 nit: his isn't actually specific to screens - it's nit: his isn't actually specific to screens - it's really just a general dimensions & density structure. Call it e.g. ImageResolution? alexeypa (please no reviews) 2013/03/16 22:20:09 Done. Show quoted text On 2013/03/16 01:03:25, Wez wrote: > nit: the -> a Done. alexeypa (please no reviews) 2013/03/16 22:20:09 I prefer to leave it as it is. I don't think is it Show quoted text On 2013/03/16 01:03:25, Wez wrote: > nit: his isn't actually specific to screens - it's really just a general > dimensions & density structure. Call it e.g. ImageResolution? I prefer to leave it as it is. I don't think is it ready to be a general-purpose structure.
	16 struct ScreenResolution {
	Wez 2013/03/16 01:03:25 As per style-guide this should be a class, not a s As per style-guide this should be a class, not a struct, since ScaleDimensionsToDpi() isn't a simple initializer, setter, or validator. alexeypa (please no reviews) 2013/03/16 22:20:09 Done. Show quoted text On 2013/03/16 01:03:25, Wez wrote: > As per style-guide this should be a class, not a struct, since > ScaleDimensionsToDpi() isn't a simple initializer, setter, or validator. Done.
	17 ScreenResolution();

	18

	19 ScreenResolution(const SkISize& dimensions, const SkIPoint& dpi);

	20

	21 // Returns the screen dimensions scaled assording to the passed \|new_dpi\|.
	Wez 2013/03/16 01:03:25 typo: assording typo: assording alexeypa (please no reviews) 2013/03/16 22:20:09 Done. Show quoted text On 2013/03/16 01:03:25, Wez wrote: > typo: assording Done.
	22 SkISize ScaleDimensionsToDpi(const SkIPoint& new_dpi) const;
	Wez 2013/03/16 01:03:25 The problem with general scale to DPI is that it m The problem with general scale to DPI is that it may result in fractional coordinates, and if applied to actually imagery it could make things blurry. We really only use this to normalize from potentially-high-DPI to 96dpi, and we expect to always be called with some multiple like 192dpi, so can we instead have a more specific function that will only scale up or down by integer amounts to get as close as possible to 96dpi? alexeypa (please no reviews) 2013/03/16 22:20:09 This change does not belong to this CL. Show quoted text On 2013/03/16 01:03:25, Wez wrote: > The problem with general scale to DPI is that it may result in fractional > coordinates, and if applied to actually imagery it could make things blurry. We > really only use this to normalize from potentially-high-DPI to 96dpi, and we > expect to always be called with some multiple like 192dpi, so can we instead > have a more specific function that will only scale up or down by integer amounts > to get as close as possible to 96dpi? This change does not belong to this CL.
	23

	24 // Returns true if \|dimensions_\| specifies an empty rectangle or when

	25 // IsValid() returns false.

	26 bool IsEmpty() const;

	27

	28 // Returns true if both \|dimensions_\| and \|dpi_\| are valid. \|dimensions_\|

	29 // specifying an empty rectangle is considered to be valid.

	30 bool IsValid() const;

	31

	32 // Dimensions of the screen in pixels.

	33 SkISize dimensions_;
	Wez 2013/03/16 01:03:25 As per style-guide, struct members shouldn't have As per style-guide, struct members shouldn't have trailing _. alexeypa (please no reviews) 2013/03/16 22:20:09 It is a class now. Show quoted text On 2013/03/16 01:03:25, Wez wrote: > As per style-guide, struct members shouldn't have trailing _. It is a class now.
	34

	35 // The vertical and horizontal DPI of the screen.

	36 SkIPoint dpi_;

	37 };

	38

	39 } // namespace remoting

	40

	41 #endif // REMOTING_HOST_SCREEN_RESOLUTION_H_

OLD	NEW

« no previous file with comments | « remoting/host/resizing_host_observer_unittest.cc ('k') | remoting/host/screen_resolution.cc » ('j') | no next file with comments »