Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1266943005: Fix http requests and the crash dump RPC (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix http requests and the crash dump RPC - Fix HTTP and crash dump service requests by giving them a non-null id. - Add basic heartbeat test for _getCrashDump RPC over HTTP. - Fix some analyzer warnings. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/fc2d849cd5920ba0bb7bb005748c4df6701993a8

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -9 lines) Patch
M runtime/bin/vmservice/server.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 1 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/elements/logging.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/view_footer.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A runtime/observatory/tests/service/crash_dump_test.dart View 1 2 3 1 chunk +34 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/test_helper.dart View 3 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/service/message.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/service/vmservice.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 4 months ago (2015-07-31 20:34:02 UTC) #2
rmacnak
lgtm https://chromiumcodereview.appspot.com/1266943005/diff/40001/runtime/observatory/tests/service/crash_dump_test.dart File runtime/observatory/tests/service/crash_dump_test.dart (right): https://chromiumcodereview.appspot.com/1266943005/diff/40001/runtime/observatory/tests/service/crash_dump_test.dart#newcode25 runtime/observatory/tests/service/crash_dump_test.dart:25: String responseString = ''; Large response, use a ...
5 years, 4 months ago (2015-07-31 21:24:53 UTC) #3
Cutch
https://chromiumcodereview.appspot.com/1266943005/diff/40001/runtime/observatory/tests/service/crash_dump_test.dart File runtime/observatory/tests/service/crash_dump_test.dart (right): https://chromiumcodereview.appspot.com/1266943005/diff/40001/runtime/observatory/tests/service/crash_dump_test.dart#newcode25 runtime/observatory/tests/service/crash_dump_test.dart:25: String responseString = ''; On 2015/07/31 21:24:53, rmacnak wrote: ...
5 years, 4 months ago (2015-07-31 21:37:44 UTC) #4
Cutch
5 years, 4 months ago (2015-07-31 21:38:08 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
fc2d849cd5920ba0bb7bb005748c4df6701993a8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698