Issue 12668004: Add dart:typeddata to the SDK and add an unimplemented patch file for dart2js.

Issue 12668004: Add dart:typeddata to the SDK and add an unimplemented patch file for dart2js. (Closed)

Created:
7 years, 9 months ago by siva

Modified:
7 years, 9 months ago

Reviewers:
sra1, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add dart:typeddata to the SDK and add an unimplemented patch file for dart2js. Committed: https://code.google.com/p/dart/source/detail?r=19709

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -5 lines)			Patch
A	sdk/lib/_internal/compiler/implementation/lib/typeddata_patch.dart	View		1 chunk	+151 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/libraries.dart	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

Additional small comment. -Ivan https://chromiumcodereview.appspot.com/12668004/diff/1/sdk/lib/_internal/libraries.dart File sdk/lib/_internal/libraries.dart (right): https://chromiumcodereview.appspot.com/12668004/diff/1/sdk/lib/_internal/libraries.dart#newcode94 sdk/lib/_internal/libraries.dart:94: category: "Server", I would believe ...

7 years, 9 months ago (2013-03-08 09:41:52 UTC) #3

sra1

lgtm if supported on Client https://chromiumcodereview.appspot.com/12668004/diff/1/sdk/lib/_internal/libraries.dart File sdk/lib/_internal/libraries.dart (right): https://chromiumcodereview.appspot.com/12668004/diff/1/sdk/lib/_internal/libraries.dart#newcode94 sdk/lib/_internal/libraries.dart:94: category: "Server", On 2013/03/08 ...

7 years, 9 months ago (2013-03-08 18:52:24 UTC) #4

siva

https://chromiumcodereview.appspot.com/12668004/diff/1/sdk/lib/_internal/libraries.dart File sdk/lib/_internal/libraries.dart (right): https://chromiumcodereview.appspot.com/12668004/diff/1/sdk/lib/_internal/libraries.dart#newcode94 sdk/lib/_internal/libraries.dart:94: category: "Server", Changed it to "Common" On 2013/03/08 09:41:52, ...

7 years, 9 months ago (2013-03-08 18:57:40 UTC) #5

siva

7 years, 9 months ago (2013-03-08 19:02:37 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r19709 (presubmit successful).

Expand Messages | Collapse Messages