Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1166)

Issue 12667019: [MIPS] Support for building tests for MIPS (Closed)

Created:
7 years, 9 months ago by petarj
Modified:
7 years, 9 months ago
Reviewers:
Mark Seaborn
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/src/native_client.git@master
Visibility:
Public.

Description

[MIPS] Support for building tests for MIPS This change includes set of small changes to enable building the tests for MIPS. BUG= https://code.google.com/p/nativeclient/issues/detail?id=2275 TEST= ./scons hello_world --mode=nacl platform=mips32 --verbose Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=10972

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates to sandboxed_mips.S. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -14 lines) Patch
M run.py View 9 chunks +24 lines, -6 lines 0 comments Download
M tests/callingconv/nacl.scons View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/callingconv_case_by_case/nacl.scons View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/callingconv_ppapi/nacl.scons View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/egyptian_cotton/nacl.scons View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/gdb/nacl.scons View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/syscall_return_sandboxing/nacl.scons View 1 chunk +2 lines, -0 lines 0 comments Download
A tests/syscall_return_sandboxing/sandboxed_mips.S View 1 1 chunk +68 lines, -0 lines 1 comment Download
A + tests/thread_capture/arch/mips/thread_capture_test_injection.c View 1 chunk +1 line, -2 lines 0 comments Download
M tests/thread_capture/nacl.scons View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/thread_capture/nacl_thread_capture_test_injection_test.c View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
petarj
A subset of changes at https://codereview.chromium.org/12256018/
7 years, 9 months ago (2013-03-12 00:12:53 UTC) #1
Mark Seaborn
LGTM, thanks https://codereview.chromium.org/12667019/diff/1/tests/syscall_return_sandboxing/sandboxed_mips.S File tests/syscall_return_sandboxing/sandboxed_mips.S (right): https://codereview.chromium.org/12667019/diff/1/tests/syscall_return_sandboxing/sandboxed_mips.S#newcode37 tests/syscall_return_sandboxing/sandboxed_mips.S:37: nop /* sandboxed (bundle aligned) return address ...
7 years, 9 months ago (2013-03-12 00:39:28 UTC) #2
petarj
Second patch set uploaded.
7 years, 9 months ago (2013-03-12 17:46:15 UTC) #3
Mark Seaborn
LGTM https://codereview.chromium.org/12667019/diff/18001/tests/syscall_return_sandboxing/sandboxed_mips.S File tests/syscall_return_sandboxing/sandboxed_mips.S (right): https://codereview.chromium.org/12667019/diff/18001/tests/syscall_return_sandboxing/sandboxed_mips.S#newcode38 tests/syscall_return_sandboxing/sandboxed_mips.S:38: nop FWIW, adding in ".p2align 4" as well ...
7 years, 9 months ago (2013-03-12 21:55:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://nativeclient-status.appspot.com/cq/petarj@mips.com/12667019/18001
7 years, 9 months ago (2013-03-12 22:32:33 UTC) #5
commit-bot: I haz the power
7 years, 9 months ago (2013-03-13 00:43:40 UTC) #6
Message was sent while issue was closed.
Change committed as 10972

Powered by Google App Engine
This is Rietveld 408576698