Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: tests/gdb/nacl.scons

Issue 12667019: [MIPS] Support for building tests for MIPS (Closed) Base URL: http://git.chromium.org/native_client/src/native_client.git@master
Patch Set: updates to sandboxed_mips.S. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/gdb/nacl.scons
diff --git a/tests/gdb/nacl.scons b/tests/gdb/nacl.scons
index fe7ff9531e9c2c711e15a3c5518b9fdfd673c685..1185e297ea99647cf008037c0b9bb75afd94afff 100644
--- a/tests/gdb/nacl.scons
+++ b/tests/gdb/nacl.scons
@@ -8,12 +8,12 @@ Import('env')
if 'TRUSTED_ENV' not in env:
Return()
-if env.Bit('target_arm'):
+if env.Bit('target_arm') or env.Bit('target_mips32'):
if env.UsingEmulator():
- # These tests do not work under qemu-arm.
+ # These tests do not work under qemu.
Return()
- # Use the system's ARM GDB because the NaCl toolchain does not
- # include a copy of GDB built to run on ARM.
+ # Use the system's ARM/MIPS GDB because the NaCl toolchain does not
+ # include a copy of GDB built to run on ARM/MIPS.
env.Replace(GDB='gdb')
# Unlike nacl-gdb, the system version of GDB does not support the
# "nacl-irt" command.
@@ -95,7 +95,7 @@ node = env.CommandTest(
# TODO(mseaborn): Investigate and enable this test.
# http://code.google.com/p/nativeclient/issues/detail?id=3252
env.AddNodeToTestSuite(node, test_suites, 'run_gdb_stack_trace_test',
- is_broken=env.Bit('bitcode') and env.Bit('target_arm'))
+ is_broken=env.Bit('bitcode'))
env.TestBindsFixedTcpPort(node)
node = env.CommandTest(
@@ -127,7 +127,7 @@ node = env.CommandTest(
# TODO(mseaborn): Investigate and enable this test.
# http://code.google.com/p/nativeclient/issues/detail?id=3252
env.AddNodeToTestSuite(node, test_suites, 'run_gdb_change_variable_test',
- is_broken=env.Bit('bitcode') and env.Bit('target_arm'))
+ is_broken=env.Bit('bitcode'))
env.TestBindsFixedTcpPort(node)
if not env.Bit('nacl_static_link'):

Powered by Google App Engine
This is Rietveld 408576698