[rAC, OSX] Enable requestAutocomplet for OSX

[rAC, OSX] Enable requestAutocomplet for OSX

Turns on requestAutocomplete behind a flag for OSX. Other implementations are still on by default. (OSX will be on by default when the UI has parity)

BUG=157274
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204936

[groby-ooo-7-16, 2013-06-07 00:48:50]

sky, PTAL
abodenha: So you're aware it's happening :)

Feel free to submit to CQ if you el-gee-tee-em it - I'm OOO until Tuesday. Or
wait till I come back :)

[sky, 2013-06-07 16:48:03]

https://codereview.chromium.org/12662017/diff/2001/chrome/renderer/chrome_ren...
File chrome/renderer/chrome_render_process_observer.cc (right):

https://codereview.chromium.org/12662017/diff/2001/chrome/renderer/chrome_ren...
chrome/renderer/chrome_render_process_observer.cc:168: #if defined(OS_MACOSX)
Is there some central autofill class we can add a static method to that has this
check. I'm thinking something Autofill::IsEnableInteractiveAutocompleteEnabled()

[Albert Bodenhamer, 2013-06-07 17:03:59]

https://codereview.chromium.org/12662017/diff/2001/chrome/renderer/chrome_ren...
File chrome/renderer/chrome_render_process_observer.cc (right):

https://codereview.chromium.org/12662017/diff/2001/chrome/renderer/chrome_ren...
chrome/renderer/chrome_render_process_observer.cc:168: #if defined(OS_MACOSX)
On 2013/06/07 16:48:03, sky wrote:
> Is there some central autofill class we can add a static method to that has
this
> check. I'm thinking something
Autofill::IsEnableInteractiveAutocompleteEnabled()

autofill_switches might work, but the code is only ever needed here.  I'd prefer
to limit the scope.

I'd lean towards pulling the check into a static function here.

[sky, 2013-06-07 17:56:57]

Go ahead and keep it here for now.

[sky, 2013-06-07 17:57:01]

LGTM

[commit-bot: I haz the power, 2013-06-07 17:57:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/groby@chromium.org/12662017/2001

[commit-bot: I haz the power, 2013-06-07 21:38:39]

Change committed as 204936