[rAC, OSX] Enable requestAutocomplet for OSX

chrome/renderer/chrome_render_process_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_render_process_observer.h"
 
 #include <limits>
 #include <vector>
 
 #include "base/allocator/allocator_extension.h"
@@ skipping 147 matching lines @@
 ChromeRenderProcessObserver::ChromeRenderProcessObserver(
     chrome::ChromeContentRendererClient* client)
     : client_(client),
       clear_cache_pending_(false) {
   const CommandLine& command_line = *CommandLine::ForCurrentProcess();
   if (command_line.HasSwitch(switches::kEnableWatchdog)) {
     // TODO(JAR): Need to implement renderer IO msgloop watchdog.
   }
 
 #if defined(ENABLE_AUTOFILL_DIALOG)
+#if defined(OS_MACOSX)

[sky, 2013/06/07 16:48:03]

Is there some central autofill class we can add a static method to that has this
check. I'm thinking something Autofill::IsEnableInteractiveAutocompleteEnabled()

[Albert Bodenhamer, 2013/06/07 17:03:59]

autofill_switches might work, but the code is only ever needed here.  I'd prefer
to limit the scope.

I'd lean towards pulling the check into a static function here.

+  bool enableAutofill = command_line.HasSwitch(
+      autofill::switches::kEnableInteractiveAutocomplete);
+#else
+  bool enableAutofill = !command_line.HasSwitch(
+      autofill::switches::kDisableInteractiveAutocomplete);
+#endif
   WebRuntimeFeatures::enableRequestAutocomplete(
-      !command_line.HasSwitch(
-          autofill::switches::kDisableInteractiveAutocomplete) ||
+      enableAutofill ||
       command_line.HasSwitch(switches::kEnableExperimentalWebKitFeatures));
 #endif
 
   RenderThread* thread = RenderThread::Get();
   resource_delegate_.reset(new RendererResourceDelegate());
   thread->SetResourceDispatcherDelegate(resource_delegate_.get());
 
   // Configure modules that need access to resources.
   net::NetModule::SetResourceProvider(chrome_common_net::NetResourceProvider);
 
@@ skipping 137 matching lines @@
   if (clear_cache_pending_) {
     clear_cache_pending_ = false;
     WebCache::clear();
   }
 }
 
 const RendererContentSettingRules*
 ChromeRenderProcessObserver::content_setting_rules() const {
   return &content_setting_rules_;
 }