Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 12662006: This changes fixes issues with the non-separable blend modes. They were not producing the correct r… (Closed)

Created:
7 years, 9 months ago by RikC
Modified:
7 years, 9 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Visibility:
Public.

Description

This changes fixes issues with the non-separable blend modes. They were not producing the correct results if alpha was involved. I fixed the math so everything happens in premultiplied alpha so there is no loss in precision. I also fixed the math of color-burn and color-dodge. Committed: http://code.google.com/p/skia/source/detail?r=8283

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -72 lines) Patch
M src/core/SkXfermode.cpp View 1 2 3 8 chunks +43 lines, -72 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
RikC
7 years, 9 months ago (2013-03-11 22:24:14 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
7 years, 9 months ago (2013-03-21 12:39:32 UTC) #2
reed1
lgtm
7 years, 9 months ago (2013-03-21 12:39:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/cabanier@gmail.com/12662006/9001
7 years, 9 months ago (2013-03-21 12:40:02 UTC) #4
commit-bot: I haz the power
7 years, 9 months ago (2013-03-21 12:40:12 UTC) #5
Message was sent while issue was closed.
Change committed as 8283

Powered by Google App Engine
This is Rietveld 408576698