Issue 12650005: Parallel recompilation: fix off-by-one in deferred handle scope iteration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12650005: Parallel recompilation: fix off-by-one in deferred handle scope iteration. (Closed)

Created:
7 years, 9 months ago by Yang

Modified:
7 years, 9 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Parallel recompilation: fix off-by-one in deferred handle scope iteration. R=jkummerow@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13962

Patch Set 1 #

Total comments: 1

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -2 lines)			Patch
M	src/api.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/compiler.cc	View	1 chunk	+1 line, -1 line	1 comment	Download
M	test/cctest/test-heap.cc	View	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

lgtm https://chromiumcodereview.appspot.com/12650005/diff/1/src/compiler.cc File src/compiler.cc (right): https://chromiumcodereview.appspot.com/12650005/diff/1/src/compiler.cc#newcode946 src/compiler.cc:946: // Do a scavenge to put off the ...

7 years, 9 months ago (2013-03-18 10:22:19 UTC) #2

Yang

7 years, 9 months ago (2013-03-18 11:26:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r13962 (presubmit successful).

Expand Messages | Collapse Messages