src/compiler.cc - Issue 12650005: Parallel recompilation: fix off-by-one in deferred handle scope iteration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler.cc

Issue 12650005: Parallel recompilation: fix off-by-one in deferred handle scope iteration. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler.cc

diff --git a/src/compiler.cc b/src/compiler.cc

index e51fb42c8f9c484bcf768b440541e5b80e951517..401e4edc6d7af8befd1cccf2d1d1b76fa61f5542 100644

--- a/src/compiler.cc

+++ b/src/compiler.cc

@@ -945,9 +945,9 @@ void Compiler::RecompileParallel(Handle<JSFunction> closure) {

if (status == OptimizingCompiler::SUCCEEDED) {

// Do a scavenge to put off the next scavenge as far as possible.

Jakob Kummerow 2013/03/18 10:22:19 Please move this comment along with the line it ap

// This may ease the issue that GVN blocks the next scavenge.

- isolate->heap()->CollectGarbage(NEW_SPACE, "parallel recompile");

shared->code()->set_profiler_ticks(0);

info.Detach();

+ isolate->heap()->CollectGarbage(NEW_SPACE, "parallel recompile");

isolate->optimizing_compiler_thread()->QueueForOptimization(compiler);

} else if (status == OptimizingCompiler::BAILED_OUT) {

isolate->clear_pending_exception();

« no previous file with comments | « src/api.cc ('k') | test/cctest/test-heap.cc » ('j') | no next file with comments »