Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12647003: Refactor a bunch of Texture related GPU code (Closed)

Created:
7 years, 9 months ago by greggman
Modified:
7 years, 9 months ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Refactor a bunch of Texture related GPU code Rename info->texture Move TexParameter guts into TextureManager BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=187120

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : fix mailboxes #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1209 lines, -1106 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 2 9 chunks +27 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager_unittest.cc View 16 chunks +41 lines, -33 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 5 71 chunks +226 lines, -250 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 2 3 4 5 47 chunks +176 lines, -160 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 30 chunks +64 lines, -64 lines 0 comments Download
M gpu/command_buffer/service/test_helper.h View 2 chunks +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/test_helper.cc View 2 chunks +23 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 1 7 chunks +25 lines, -21 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 2 3 4 14 chunks +162 lines, -135 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 21 chunks +458 lines, -438 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
greggman
Hey Al, PTAL I was going to move more texture functions from gles2_cmd_decoder.cc to texture_manager.cc ...
7 years, 9 months ago (2013-03-07 22:37:26 UTC) #1
apatrick_chromium
lgtm https://codereview.chromium.org/12647003/diff/1/gpu/command_buffer/service/texture_manager.cc File gpu/command_buffer/service/texture_manager.cc (right): https://codereview.chromium.org/12647003/diff/1/gpu/command_buffer/service/texture_manager.cc#newcode1230 gpu/command_buffer/service/texture_manager.cc:1230: pending_async_transfers_.push_back(PendingAsyncTransfer(state,texture)); space after comma
7 years, 9 months ago (2013-03-07 23:22:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/12647003/23001
7 years, 9 months ago (2013-03-08 00:07:51 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=17552
7 years, 9 months ago (2013-03-08 03:56:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/12647003/23001
7 years, 9 months ago (2013-03-08 04:43:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/12647003/52001
7 years, 9 months ago (2013-03-08 11:41:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/12647003/68001
7 years, 9 months ago (2013-03-08 15:38:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/12647003/40002
7 years, 9 months ago (2013-03-08 20:16:02 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) gpu_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=91244
7 years, 9 months ago (2013-03-08 21:05:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/12647003/28003
7 years, 9 months ago (2013-03-08 22:02:43 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=120228
7 years, 9 months ago (2013-03-08 23:17:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/12647003/28003
7 years, 9 months ago (2013-03-09 00:57:04 UTC) #12
commit-bot: I haz the power
7 years, 9 months ago (2013-03-09 02:40:10 UTC) #13
Message was sent while issue was closed. 
Change committed as 187120

Powered by Google App Engine
This is Rietveld 408576698